Skip to content

Commit aa1d469

Browse files
committed
Avoid unnecessary Dictionary conversions in GDScriptInstance::validate_property
Updated GDScriptInstance::validate_property to only convert PropertyInfo to Dictionary if _validate_property function is found.
1 parent 4631a61 commit aa1d469

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

modules/gdscript/gdscript.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1835,14 +1835,14 @@ Variant::Type GDScriptInstance::get_property_type(const StringName &p_name, bool
18351835
}
18361836

18371837
void GDScriptInstance::validate_property(PropertyInfo &p_property) const {
1838-
Variant property = (Dictionary)p_property;
1839-
const Variant *args[1] = { &property };
1840-
18411838
const GDScript *sptr = script.ptr();
18421839
while (sptr) {
18431840
if (likely(sptr->valid)) {
18441841
HashMap<StringName, GDScriptFunction *>::ConstIterator E = sptr->member_functions.find(GDScriptLanguage::get_singleton()->strings._validate_property);
18451842
if (E) {
1843+
Variant property = (Dictionary)p_property;
1844+
const Variant *args[1] = { &property };
1845+
18461846
Callable::CallError err;
18471847
Variant ret = E->value->call(const_cast<GDScriptInstance *>(this), args, 1, err);
18481848
if (err.error == Callable::CallError::CALL_OK) {

0 commit comments

Comments
 (0)