Merge pull request #96209 from stuartcarnie/sgc/96077/fix_sdfgi

akien-mga · akien-mga · commit f648de1a83cf · 2024-08-28T13:14:34.000+02:00
Metal: Use correct operator to ensure specialisation constants are sorted
diff --git a/drivers/metal/rendering_device_driver_metal.mm b/drivers/metal/rendering_device_driver_metal.mm
@@ -3112,7 +3112,7 @@ bool isArrayTexture(MTLTextureType p_type) {
 	NSArray<MTLFunctionConstant *> *constants = function.functionConstantsDictionary.allValues;
 	bool is_sorted = true;
 	for (uint32_t i = 1; i < constants.count; i++) {
-		if (constants[i - 1].index < constants[i].index) {
+		if (constants[i - 1].index > constants[i].index) {
 			is_sorted = false;
 			break;
 		}

Original file line number	Diff line number	Diff line change
`@@ -3112,7 +3112,7 @@ bool isArrayTexture(MTLTextureType p_type) {`
`3112`	`3112`	`NSArray<MTLFunctionConstant > constants = function.functionConstantsDictionary.allValues;`
`3113`	`3113`	`bool is_sorted = true;`
`3114`	`3114`	`for (uint32_t i = 1; i < constants.count; i++) {`
`3115`		`- if (constants[i - 1].index < constants[i].index) {`
	`3115`	`+ if (constants[i - 1].index > constants[i].index) {`
`3116`	`3116`	`is_sorted = false;`
`3117`	`3117`	`break;`
`3118`	`3118`	`}`