Skip to content

Commit 0b676c3

Browse files
committed
Apply small adjustments to AuthnRequest and AuthnRequestParams
Since all the getters of AuthnRequestParams are protected, it makes sense for the getAttributeConsumingServiceSelector to be protected as well. Also, implement AuthnRequest(settings) constructor with a call to another non-deprecated constructor.
1 parent 6fd598a commit 0b676c3

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

core/src/main/java/com/onelogin/saml2/authn/AuthnRequest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,10 @@ public class AuthnRequest extends AuthnRequestParams {
5252
*
5353
* @param settings
5454
* OneLogin_Saml2_Settings
55+
* @see #AuthnRequest(Saml2Settings, AuthnRequestParams)
5556
*/
5657
public AuthnRequest(Saml2Settings settings) {
57-
this(settings, false, false, true);
58+
this(settings, new AuthnRequestParams(false, false, true));
5859
}
5960

6061
/**

core/src/main/java/com/onelogin/saml2/authn/AuthnRequestParams.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ protected String getNameIdValueReq() {
163163
/**
164164
* @return the selector to use to specify the Attribute Consuming Service index
165165
*/
166-
public AttributeConsumingServiceSelector getAttributeConsumingServiceSelector() {
166+
protected AttributeConsumingServiceSelector getAttributeConsumingServiceSelector() {
167167
return attributeConsumingServiceSelector;
168168
}
169169
}

0 commit comments

Comments
 (0)