Apply minor adjustments to AuthnRequest/LogoutRequest APIs and tests

These details were overlooked in the first place: getters of the input
params should better be public and fields can be declared as final.
The useless NameId setter in LogoutRequestParams was temporarily
introduced during development but should have been reverted from the
beginning, so it's gone now.

Some tests were improved to provide more accurate assertions.

Author: mauromol

core/src/main/java/com/onelogin/saml2/authn/AuthnRequestParams.java

@@ -77,29 +77,29 @@ protected AuthnRequestParams(AuthnRequestParams source) {
 	 * @return whether the <code>ForceAuthn</code> attribute should be set to
 	 *         <code>true</code>
 	 */
-	protected boolean isForceAuthn() {
+	public boolean isForceAuthn() {
 		return forceAuthn;
 	}
 
 	/**
 	 * @return whether the <code>isPassive</code> attribute should be set to
 	 *         <code>true</code>
 	 */
-	protected boolean isPassive() {
+	public boolean isPassive() {
 		return isPassive;
 	}
 
 	/**
 	 * @return whether a <code>NameIDPolicy</code> should be set
 	 */
-	protected boolean isSetNameIdPolicy() {
+	public boolean isSetNameIdPolicy() {
 		return setNameIdPolicy;
 	}
 
 	/**
 	 * @return the subject that should be authenticated
 	 */
-	protected String getNameIdValueReq() {
+	public String getNameIdValueReq() {
 		return nameIdValueReq;
 	}
 }

core/src/main/java/com/onelogin/saml2/logout/LogoutRequest.java

@@ -242,7 +242,7 @@ public LogoutRequest(Saml2Settings settings, HttpRequest request) {
 	 * @param settings
 	 *              OneLogin_Saml2_Settings
 	 * @param params
-	 *              a set of authentication request input parameters that shape the
+	 *              a set of logout request input parameters that shape the
 	 *              request to create
 	 */
 	public LogoutRequest(Saml2Settings settings, LogoutRequestParams params) {

core/src/main/java/com/onelogin/saml2/logout/LogoutRequestParams.java

@@ -9,30 +9,31 @@ public class LogoutRequestParams {
 	 * SessionIndex. When the user is logged, this stored it from the AuthnStatement
 	 * of the SAML Response
 	 */
-	private String sessionIndex;
+	private final String sessionIndex;
 
 	/**
 	 * NameID.
 	 */
-	private String nameId;
+	private final String nameId;
 
 	/**
 	 * NameID Format.
 	 */
-	private String nameIdFormat;
+	private final String nameIdFormat;
 
 	/**
 	 * nameId NameQualifier
 	 */
-	private String nameIdNameQualifier;
+	private final String nameIdNameQualifier;
 
 	/**
 	 * nameId SP NameQualifier
 	 */
-	private String nameIdSPNameQualifier;
+	private final String nameIdSPNameQualifier;
 
 	/** Create an empty set of logout request input parameters. */
 	public LogoutRequestParams() {
+		this(null, null);
 	}
 
 	/**
@@ -118,45 +119,35 @@ protected LogoutRequestParams(LogoutRequestParams source) {
 	/**
 	 * @return the name ID
 	 */
-	protected String getNameId() {
+	public String getNameId() {
 		return nameId;
 	}
 
-	/**
-	 * Sets the name ID
-	 * 
-	 * @param nameId
-	 *              the name ID to set
-	 */
-	protected void setNameId(String nameId) {
-		this.nameId = nameId;
-	}
-
 	/**
 	 * @return the name ID format
 	 */
-	protected String getNameIdFormat() {
+	public String getNameIdFormat() {
 		return nameIdFormat;
 	}
 
 	/**
 	 * @return the name ID name qualifier
 	 */
-	protected String getNameIdNameQualifier() {
+	public String getNameIdNameQualifier() {
 		return nameIdNameQualifier;
 	}
 
 	/**
 	 * @return the name ID SP name qualifier
 	 */
-	protected String getNameIdSPNameQualifier() {
+	public String getNameIdSPNameQualifier() {
 		return nameIdSPNameQualifier;
 	}
 
 	/**
 	 * @return the session index
 	 */
-	protected String getSessionIndex() {
+	public String getSessionIndex() {
 		return sessionIndex;
 	}
 }

core/src/test/java/com/onelogin/saml2/test/logout/LogoutRequestTest.java

@@ -1095,11 +1095,13 @@ private static HttpRequest newHttpRequest(String requestURL, String samlRequestE
 	@Test
 	public void testPostProcessXml() throws Exception {
 		Saml2Settings settings = new SettingsBuilder().fromFile("config/config.min.properties").build();
-		LogoutRequest logoutRequest = new LogoutRequest(settings) {
+		final LogoutRequestParams params = new LogoutRequestParams();
+		LogoutRequest logoutRequest = new LogoutRequest(settings, params) {
 			@Override
-			protected String postProcessXml(String logoutRequestXml, LogoutRequestParams params, Saml2Settings sett) {
-				assertEquals(logoutRequestXml, super.postProcessXml(logoutRequestXml, params, sett));
+			protected String postProcessXml(String logoutRequestXml, LogoutRequestParams par, Saml2Settings sett) {
+				assertEquals(logoutRequestXml, super.postProcessXml(logoutRequestXml, par, sett));
 				assertSame(settings, sett);
+				assertSame(params, par);
 				return "changed";
 			}
 		};