Fix #487. Enable strict check on in_array method

pitbulk · pitbulk · commit 107757b29402 · 2021-09-06T17:34:59.000+02:00
diff --git a/src/Saml2/Response.php b/src/Saml2/Response.php
@@ -814,7 +814,7 @@ private function _getAttributesByKeyName($keyName = "Name")
                 continue;
             }
             $attributeKeyName = $attributeKeyNode->nodeValue;
-            if (in_array($attributeKeyName, array_keys($attributes))) {
+            if (in_array($attributeKeyName, array_keys($attributes), true)) {
                 if (!$allowRepeatAttributeName) {
                     throw new ValidationError(
                         "Found an Attribute element with duplicated ".$keyName,
@@ -830,7 +830,7 @@ private function _getAttributesByKeyName($keyName = "Name")
                 }
             }
 
-            if (in_array($attributeKeyName, array_keys($attributes))) {
+            if (in_array($attributeKeyName, array_keys($attributes), true)) {
                 $attributes[$attributeKeyName] = array_merge($attributes[$attributeKeyName], $attributeValues);
             } else {
                 $attributes[$attributeKeyName] = $attributeValues;

Original file line number	Diff line number	Diff line change
`@@ -814,7 +814,7 @@ private function _getAttributesByKeyName($keyName = "Name")`
`814`	`814`	`continue;`
`815`	`815`	`}`
`816`	`816`	`$attributeKeyName = $attributeKeyNode->nodeValue;`
`817`		`- if (in_array($attributeKeyName, array_keys($attributes))) {`
	`817`	`+ if (in_array($attributeKeyName, array_keys($attributes), true)) {`
`818`	`818`	`if (!$allowRepeatAttributeName) {`
`819`	`819`	`throw new ValidationError(`
`820`	`820`	`"Found an Attribute element with duplicated ".$keyName,`
`@@ -830,7 +830,7 @@ private function _getAttributesByKeyName($keyName = "Name")`
`830`	`830`	`}`
`831`	`831`	`}`
`832`	`832`
`833`		`- if (in_array($attributeKeyName, array_keys($attributes))) {`
	`833`	`+ if (in_array($attributeKeyName, array_keys($attributes), true)) {`
`834`	`834`	`$attributes[$attributeKeyName] = array_merge($attributes[$attributeKeyName], $attributeValues);`
`835`	`835`	`} else {`
`836`	`836`	`$attributes[$attributeKeyName] = $attributeValues;`