Skip to content

Commit 5c507b4

Browse files
Merge pull request #175 from SciML/compathelper/new_version/2025-04-16-00-08-43-033-01194679780
CompatHelper: bump compat for Catalyst to 15, (keep existing compat)
2 parents 99dcab2 + f3d5792 commit 5c507b4

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ SymbolicUtils = "d1185830-fcd6-423d-90d6-eec64667417b"
1111
[compat]
1212
Aqua = "0.8"
1313
CSV = "0.10.5"
14-
Catalyst = "14"
14+
Catalyst = "14, 15"
1515
DataFrames = "1"
1616
Downloads = "1"
1717
ModelingToolkit = "9"

test/systems.jl

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ using Catalyst, SBML
33
using Test
44

55
cd(@__DIR__)
6-
sbmlfile = joinpath("data", "reactionsystem_01.xml")
6+
sbmlfile = joinpath("test", "data", "reactionsystem_01.xml")
77
const IV = default_t()
88
@parameters k1, c1
99
@species s1(IV), s2(IV), s1s2(IV)
@@ -83,10 +83,11 @@ trueeqs = Equation[default_time_deriv()(s1) ~ k1]
8383
@test isequal(Catalyst.get_eqs(odesys), trueeqs)
8484
@test isequal(Catalyst.get_iv(odesys), IV)
8585
@test isequal(Catalyst.get_unknowns(odesys), [s1])
86-
@test issetequal(Catalyst.get_ps(odesys), [k1, c1])
86+
@test issetequal(ModelingToolkit.parameters_toplevel(odesys), [k1, c1])
8787
u0 = [s1 => 1.0]
8888
par = [k1 => 1.0, c1 => 2.0]
89-
@test isequal(ModelingToolkit.defaults(odesys), ModelingToolkit._merge(u0, par)) # PL: @Anand: for some reason this does not work with `Catalyst.get_default()`
89+
testdef = merge(Dict(u0), Dict(par))
90+
@test issubset(testdef, defaults(odesys))
9091
@named odesys = ODESystem(MODEL1)
9192
isequal(nameof(odesys), :odesys)
9293
@test structural_simplify(odesys) isa ODESystem
@@ -99,10 +100,11 @@ trueeqs = Equation[default_time_deriv()(s1) ~ -((k1 * s1 * s2) / c1),
99100
@test isequal(Catalyst.get_eqs(odesys), trueeqs)
100101
@test isequal(Catalyst.get_iv(odesys), IV)
101102
@test isequal(Catalyst.get_unknowns(odesys), [s1, s1s2, s2])
102-
@test issetequal(Catalyst.get_ps(odesys), [k1, c1])
103+
@test issetequal(Catalyst.parameters_toplevel(odesys), [k1, c1])
103104
u0 = [s1 => 2 * 1.0, s2 => 2 * 1.0, s1s2 => 2 * 1.0]
104105
par = [k1 => 1.0, c1 => 2.0]
105-
@test isequal(ModelingToolkit.defaults(odesys), ModelingToolkit._merge(u0, par))
106+
testdef = merge(Dict(u0), Dict(par))
107+
@test issubset(testdef, ModelingToolkit.defaults(odesys))
106108
@named odesys = ODESystem(MODEL1)
107109
isequal(nameof(odesys), :odesys)
108110

0 commit comments

Comments
 (0)