Get096Targets method, moved scp173Observers to method

Author: Tosoks67

Code/Helpers/Extensions/PlayerExtensions.cs

@@ -1,4 +1,5 @@
 using LabApi.Features.Wrappers;
+using PlayerRoles.PlayableScps.Scp096;
 using PlayerRoles.PlayableScps.Scp173;
 using UnityEngine;
 
@@ -23,4 +24,17 @@ public static Vector3 RelativeRoomPosition(this Player player)
             .RemoveNulls()
             .ToArray();
     }
+
+    extension(Scp096Role shyGuy)
+    {
+        public Scp096TargetsTracker TargetsTracker =>
+            !shyGuy.SubroutineModule.TryGetSubroutine(out Scp096TargetsTracker targetsTracker)
+                ? throw new Exception("My hatred towards Northwood's code grows stronger with each day.")
+                : targetsTracker;
+        
+        public Player[] Targets => shyGuy.TargetsTracker.Targets
+            .Select(Player.Get)
+            .RemoveNulls()
+            .ToArray(); 
+    }
 }

Code/MethodSystem/Methods/ScpMethods/Get096TargetsMethod.cs

@@ -0,0 +1,50 @@
+using JetBrains.Annotations;
+using LabApi.Features.Wrappers;
+using PlayerRoles.PlayableScps.Scp096;
+using SER.Code.ArgumentSystem.Arguments;
+using SER.Code.ArgumentSystem.BaseArguments;
+using SER.Code.Helpers.Exceptions;
+using SER.Code.Helpers.Extensions;
+using SER.Code.MethodSystem.BaseMethods;
+using SER.Code.MethodSystem.MethodDescriptors;
+using SER.Code.ValueSystem;
+
+namespace SER.Code.MethodSystem.Methods.ScpMethods;
+
+[UsedImplicitly]
+public class Get096TargetsMethod : ReturningMethod<PlayerValue>, ICanError
+{
+    public override string Description => "Returns the targets of the specified SCP-096";
+
+    public string[] ErrorReasons =>
+    [
+        "The specified player isn't SCP-096."
+    ];
+
+    public override Argument[] ExpectedArguments { get; } =
+    [
+        new PlayerArgument("shy guy")
+        {
+            DefaultValue = new(null, "Every target from every SCP-096")
+        }
+    ];
+
+    public override void Execute()
+    {
+        var shyGuy = Args.GetPlayer("shy guy").MaybeNull();
+
+        if (shyGuy is null)
+        {
+            ReturnValue = new PlayerValue(Player.ReadyList
+                .Select(plr => plr.RoleBase is Scp096Role paleGuy ? paleGuy.Targets : null)
+                .RemoveNulls()
+                .Flatten());
+            return;
+        }
+        
+        if (shyGuy.RoleBase is not Scp096Role shyGuyRole)
+            throw new ScriptRuntimeError(this, ErrorReasons[0]);
+        
+        ReturnValue = new PlayerValue(shyGuyRole.Targets);
+    }
+}

Code/MethodSystem/Methods/ScpMethods/Get173ObserversMethod.cs

@@ -1,15 +1,13 @@
-using Exiled.Events.Handlers;
-using JetBrains.Annotations;
+using JetBrains.Annotations;
+using LabApi.Features.Wrappers;
 using PlayerRoles.PlayableScps.Scp173;
 using SER.Code.ArgumentSystem.Arguments;
 using SER.Code.ArgumentSystem.BaseArguments;
-using SER.Code.ContextSystem.Structures;
 using SER.Code.Helpers.Exceptions;
 using SER.Code.Helpers.Extensions;
 using SER.Code.MethodSystem.BaseMethods;
 using SER.Code.MethodSystem.MethodDescriptors;
 using SER.Code.ValueSystem;
-using Player = LabApi.Features.Wrappers.Player;
 
 namespace SER.Code.MethodSystem.Methods.ScpMethods;
 
@@ -26,13 +24,25 @@ public class Get173ObserversMethod : ReturningMethod<PlayerValue>, ICanError
     public override Argument[] ExpectedArguments { get; } =
     [
         new PlayerArgument("peanut")
+        {
+            DefaultValue = new(null, "Every observer from every SCP-173")
+        }
     ];
 
     public override void Execute()
     {
-        var pnut = Args.GetPlayer("peanut");
+        var peanut = Args.GetPlayer("peanut").MaybeNull();
+
+        if (peanut is null)
+        {
+            ReturnValue = new PlayerValue(Player.ReadyList
+                .Select(plr => plr.RoleBase is Scp173Role sculpture ? sculpture.ObservingPlayers : null)
+                .RemoveNulls()
+                .Flatten());
+            return;
+        }
 
-        if (pnut.RoleBase is not Scp173Role pnutRole)
+        if (peanut.RoleBase is not Scp173Role pnutRole)
             throw new ScriptRuntimeError(this, ErrorReasons[0]);
 
         ReturnValue = new PlayerValue(pnutRole.ObservingPlayers);

Code/VariableSystem/VariableIndex.cs

@@ -21,14 +21,7 @@ public static void Initialize()
             new("all", Player.ReadyList.ToList, "Other"),
             new("alivePlayers", () => Player.ReadyList.Where(plr => plr.IsAlive).ToList(), "Other"),
             new("npcPlayers", () => Player.ReadyList.Where(plr => plr.IsNpc).ToList(), "Other"),
-            new("empty", () => [], "Other"),
-            new("scp173Observers", () => Player.ReadyList
-                    .Select(plr => plr.RoleBase is Scp173Role peanut ? peanut.ObservingPlayers : null)
-                    .RemoveNulls()
-                    .Flatten()
-                    .ToList(),
-                "SCP Specific")
-
+            new("empty", () => [], "Other")
         ];
 
         allApiVariables.AddRange(