Refactor User class to get properties individually, instead of always all in class construction

Author: SebKay

src/PostTypes/Post.php

@@ -8,7 +8,7 @@ class Post
 {
     public $id;
 
-    protected $WP_Post;
+    protected \WP_Post $WP_Post;
 
     public string $title   = '';
     public string $url     = '';
@@ -24,6 +24,8 @@ class Post
 
     public function __construct(int $id = 0)
     {
+        $this->id = $id;
+
         $this->WP_Post = \get_post($this->id);
     }
 

src/User.php

@@ -6,164 +6,123 @@
 
 class User
 {
-    protected $id;
-
-    protected $WP_User;
-
-    /**
-     * @var string
-     */
-    protected $username;
-
-    /**
-     * @var string
-     */
-    protected $nicename;
-
-    /**
-     * @var string
-     */
-    protected $displayName;
-
-    /**
-     * @var string
-     */
-    protected $email;
-
-    /**
-     * @var string
-     */
-    protected $url;
-
-    /**
-     * @var string
-     */
-    protected $registeredDate;
-
-    /**
-     * @var string
-     */
-    protected $first_name;
-
-    /**
-     * @var string
-     */
-    protected $last_name;
-
-    /**
-     * @var string
-     */
-    protected $nickname;
-
-    /**
-     * @var string
-     */
-    protected $description;
-
-    /**
-     * Set up
-     *
-     * @param integer $id
-     */
-    public function __construct(int $id)
+    public int $id;
+
+    protected \WP_User $WP_User;
+
+    public string $username       = '';
+    public string $nicename       = '';
+    public string $displayName    = '';
+    public string $email          = '';
+    public string $url            = '';
+    public Carbon $registeredDate;
+    public string $first_name     = '';
+    public string $last_name      = '';
+    public string $full_name      = '';
+    public string $nickname       = '';
+    public string $description    = '';
+
+    public function __construct(int $id = 0)
     {
-        $this->id      = $id ?: -1;
-        $this->WP_User = \get_user_by('id', $this->id());
-
-        if (!$this->WP_User) {
-            return;
-        }
-
-        //---- Data
-        $this->username       = $this->WPUser()->data->user_login;
-        $this->nicename       = $this->WPUser()->data->user_nicename;
-        $this->displayName    = $this->WPUser()->data->display_name;
-        $this->email          = $this->WPUser()->data->user_email;
-        $this->url            = $this->WPUser()->data->user_url;
-        $this->registeredDate = $this->WPUser()->data->user_registered;
-
-        //---- Meta
-        $this->first_name  = $this->meta('first_name');
-        $this->last_name   = $this->meta('last_name');
-        $this->nickname    = $this->meta('nickname');
-        $this->description = $this->meta('description');
-    }
+        $this->id = $id;
 
-    public function id()
-    {
-        return $this->id;
+        $this->WP_User = \get_user_by('id', $this->id);
+
+        $this->full_name = \trim("{$this->first_name} {$this->last_name}");
     }
 
-    public function WPUser()
+    public function exists()
     {
-        return $this->WP_User;
+        return $this->WP_User->exists();
     }
 
     /**
      * @param string $key Meta field key
      * @param bool $single Whether to return a single value or array
+     *
      * @return mixed
      */
-    public function meta(string $key, bool $single = true)
+    public function getMeta(string $key, bool $single = true)
     {
-        return \get_user_meta($this->id(), $key, $single);
+        return \get_user_meta($this->id, $key, $single);
     }
 
-    public function firstName()
+    public function withAll()
     {
-        return $this->first_name;
+        $this
+            ->withUsername()
+            ->withNicename()
+            ->withEmail()
+            ->withUrl()
+            ->withRegisteredDate()
+            ->withFirstName()
+            ->withLastName()
+            ->withNickname()
+            ->withDescription();
+
+        return $this;
     }
 
-    public function lastName()
+    public function withUsername()
     {
-        return $this->last_name;
-    }
+        $this->username = $this->WP_User->data->user_login;
 
-    public function fullName()
-    {
-        return \trim("{$this->firstName()} {$this->lastName()}");
+        return $this;
     }
 
-    public function nickname()
+    public function withNicename()
     {
-        return $this->nickname;
+        $this->displayName = $this->WP_User->data->display_name;
+
+        return $this;
     }
 
-    public function description()
+    public function withEmail()
     {
-        return \wpautop($this->description);
+        $this->email = $this->WP_User->data->user_email;
+
+        return $this;
     }
 
-    public function username()
+    public function withUrl()
     {
-        return $this->username;
+        $this->url = $this->WP_User->data->user_url;
+
+        return $this;
     }
 
-    /**
-     * * A URL friendly version of username()
-     */
-    public function nicename()
+    public function withRegisteredDate()
     {
-        return $this->nicename;
+        $this->registeredDate = new Carbon($this->WP_User->data->user_registered);
+
+        return $this;
     }
 
-    public function displayName()
+    public function withFirstName()
     {
-        return $this->displayName;
+        $this->first_name = $this->getMeta('first_name');
+
+        return $this;
     }
 
-    public function email()
+    public function withLastName()
     {
-        return $this->email;
+        $this->last_name = $this->getMeta('last_name');
+
+        return $this;
     }
 
-    public function url()
+    public function withNickname()
     {
-        return $this->url;
+        $this->nickname = $this->getMeta('nickname');
+
+        return $this;
     }
 
-    public function registredDate()
+    public function withDescription()
     {
-        return new Carbon($this->registeredDate);
+        $this->description = \wpautop($this->getMeta('description'));
+
+        return $this;
     }
 }