Skip to content

Commit 1172a6e

Browse files
renamed factories to clearer names
1 parent eb6c60b commit 1172a6e

File tree

4 files changed

+6
-19
lines changed

4 files changed

+6
-19
lines changed

build.gradle

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ task runApp3(type: JavaExec) {
8585

8686
task runApp4(type: JavaExec) {
8787
group = "Application"
88-
description = "Runs Application 4 - Nested Controllers"
88+
description = "Runs Application 4 - Table View Cell Factories"
8989
classpath sourceSets.main.runtimeClasspath
9090
main = 'org.epistatic.app4.Main'
9191
doFirst {
@@ -96,19 +96,6 @@ task runApp4(type: JavaExec) {
9696
}
9797
}
9898

99-
task runApp5(type: JavaExec) {
100-
group = "Application"
101-
description = "Runs Application 5 - Table View Cell Factories"
102-
classpath sourceSets.main.runtimeClasspath
103-
main = 'org.epistatic.app5.Main'
104-
doFirst {
105-
jvmArgs = [
106-
'--module-path', "${JFX_INSTALL}/lib",
107-
'--add-modules', 'javafx.fxml,javafx.controls'
108-
]
109-
}
110-
}
111-
11299
task collateInstall(type:Copy){
113100
delete "installBuild"
114101
mkdir "installBuild/lib"

src/main/kotlin/org/epistatic/app4/controller/ApplicationController.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,14 +59,14 @@ class ApplicationController {
5959
dateStringColumn.cellValueFactory = PropertyValueFactory<DateItem, String>("date")
6060

6161
dateObjectColumn.cellValueFactory = PropertyValueFactory<DateItem, OffsetDateTime>("date")
62-
dateObjectColumn.cellFactory = DateCellFactory1()
62+
dateObjectColumn.cellFactory = ModifiedISODateCellFactory()
6363

6464
dateCustomColumn.cellValueFactory = DateCellValueFactory()
65-
dateCustomColumn.cellFactory = DateCellFactory2()
65+
dateCustomColumn.cellFactory = ModifiedISODateCellFactory()
6666

6767
// Offset date by 10 seconds
6868
dateCustomColumn2.cellValueFactory = DateOffsetCellValueFactory(40)
69-
dateCustomColumn2.cellFactory = DateCellFactory2()
69+
dateCustomColumn2.cellFactory = CustomDateCellFactory()
7070

7171
// Use Lambda factories as lambdas
7272
dateLambdaColumn.setCellValueFactory { cell: TableColumn.CellDataFeatures<DateItem, OffsetDateTime> -> ReadOnlyObjectWrapper(cell.value.date) }

src/main/kotlin/org/epistatic/app4/controller/DateCellFactory2.kt renamed to src/main/kotlin/org/epistatic/app4/controller/CustomDateCellFactory.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import java.time.format.DateTimeFormatter
1010
/**
1111
* Sets cell's text to be another formatted date
1212
*/
13-
class DateCellFactory2 : Callback<TableColumn<DateItem, OffsetDateTime>, TableCell<DateItem, OffsetDateTime>> {
13+
class CustomDateCellFactory : Callback<TableColumn<DateItem, OffsetDateTime>, TableCell<DateItem, OffsetDateTime>> {
1414

1515
companion object {
1616
private val customFormat = DateTimeFormatter.ofPattern("MMM-dd-yyyy *** HH:mm:ss")

src/main/kotlin/org/epistatic/app4/controller/DateCellFactory1.kt renamed to src/main/kotlin/org/epistatic/app4/controller/ModifiedISODateCellFactory.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import java.time.format.DateTimeFormatter
1010
/**
1111
* Sets cell's text to be a formatted date
1212
*/
13-
class DateCellFactory1 : Callback<TableColumn<DateItem, OffsetDateTime>, TableCell<DateItem, OffsetDateTime>> {
13+
class ModifiedISODateCellFactory : Callback<TableColumn<DateItem, OffsetDateTime>, TableCell<DateItem, OffsetDateTime>> {
1414

1515
companion object {
1616
private val customFormat = DateTimeFormatter.ofPattern("yyyy-MM-dd => HH:mm:ss")

0 commit comments

Comments
 (0)