Known issue: Presence calculation doesn't currently handle multiple departures within one day where the last event is a departure

[robholmesnz]

Resolution is likely to involve creating tests which break current calculator and making changes so that these pass.

A / C

• Review with the SME's to see whether this a problem
• Write up tickets for any remaining work that needs to happen on this ticket.

[Br3nda]

Probably a days' work would get the calculation right

[CharlotteHinton]

Descoped from a discussion with Rob.

[mischa-s]

@Br3nda this work would need to happen in Open Fisca right?

[Br3nda]

No, it is in presence checker. PC works out the present_in_nz variable from movement data and sends that as input to openfisca.

Presence checker needs to correctly work out this variable when there are many movements in a day.

Consider the following:

Arriving, then leaving on the same day means you are present today (for one day), and not present tomorrow, and you stayed absent from then on.

Arriving, leaving, then arriving again all on the same day means you are present today and tomorrow, and stayed present after.

Leaving then arriving back today (or tomorrow) means you are present both days, and stayed present.

Leaving, arriving, then leaving on the same day means you are present today, but absent tomorrow and stay absent from then on

Alternative description:
work out their last movement on a day, and apply the appropriate state to tomorrow
(unless there are more movements to consider tomorrow)

[mischa-s]

okay, I might do a little spike on this then as it does feel quite important

[mischa-s]

probably looks like a refactor of /app/services/eligibility_service.rb 97 - 102