From 3e633941e7712a8fe8fab71588ea4d4939df4ead Mon Sep 17 00:00:00 2001 From: amanjaiswal73892 Date: Wed, 22 Oct 2025 16:16:49 +0000 Subject: [PATCH 1/8] rename generic_agent_hinter to hint_use_agent for clarity --- .../agents/{generic_agent_hinter => hint_use_agent}/__init__.py | 0 .../{generic_agent_hinter => hint_use_agent}/agent_configs.py | 0 .../{generic_agent_hinter => hint_use_agent}/generic_agent.py | 0 .../generic_agent_prompt.py | 0 .../{generic_agent_hinter => hint_use_agent}/tmlr_config.py | 0 5 files changed, 0 insertions(+), 0 deletions(-) rename src/agentlab/agents/{generic_agent_hinter => hint_use_agent}/__init__.py (100%) rename src/agentlab/agents/{generic_agent_hinter => hint_use_agent}/agent_configs.py (100%) rename src/agentlab/agents/{generic_agent_hinter => hint_use_agent}/generic_agent.py (100%) rename src/agentlab/agents/{generic_agent_hinter => hint_use_agent}/generic_agent_prompt.py (100%) rename src/agentlab/agents/{generic_agent_hinter => hint_use_agent}/tmlr_config.py (100%) diff --git a/src/agentlab/agents/generic_agent_hinter/__init__.py b/src/agentlab/agents/hint_use_agent/__init__.py similarity index 100% rename from src/agentlab/agents/generic_agent_hinter/__init__.py rename to src/agentlab/agents/hint_use_agent/__init__.py diff --git a/src/agentlab/agents/generic_agent_hinter/agent_configs.py b/src/agentlab/agents/hint_use_agent/agent_configs.py similarity index 100% rename from src/agentlab/agents/generic_agent_hinter/agent_configs.py rename to src/agentlab/agents/hint_use_agent/agent_configs.py diff --git a/src/agentlab/agents/generic_agent_hinter/generic_agent.py b/src/agentlab/agents/hint_use_agent/generic_agent.py similarity index 100% rename from src/agentlab/agents/generic_agent_hinter/generic_agent.py rename to src/agentlab/agents/hint_use_agent/generic_agent.py diff --git a/src/agentlab/agents/generic_agent_hinter/generic_agent_prompt.py b/src/agentlab/agents/hint_use_agent/generic_agent_prompt.py similarity index 100% rename from src/agentlab/agents/generic_agent_hinter/generic_agent_prompt.py rename to src/agentlab/agents/hint_use_agent/generic_agent_prompt.py diff --git a/src/agentlab/agents/generic_agent_hinter/tmlr_config.py b/src/agentlab/agents/hint_use_agent/tmlr_config.py similarity index 100% rename from src/agentlab/agents/generic_agent_hinter/tmlr_config.py rename to src/agentlab/agents/hint_use_agent/tmlr_config.py From a22d03705bcdb0b6f65d090e214537c9de666dd0 Mon Sep 17 00:00:00 2001 From: amanjaiswal73892 Date: Wed, 22 Oct 2025 16:53:35 +0000 Subject: [PATCH 2/8] Add deprecation warning and module alias for generic_agent_hinter --- .../agents/generic_agent_hinter/__init__.py | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 src/agentlab/agents/generic_agent_hinter/__init__.py diff --git a/src/agentlab/agents/generic_agent_hinter/__init__.py b/src/agentlab/agents/generic_agent_hinter/__init__.py new file mode 100644 index 00000000..65ab703e --- /dev/null +++ b/src/agentlab/agents/generic_agent_hinter/__init__.py @@ -0,0 +1,17 @@ +from agentlab.agents.hint_use_agent import * +import warnings +import sys + +warnings.warn( + "generic_agent_hinter is renamed to hint_use_agent.", + DeprecationWarning, + stacklevel=2, +) + +# Create module alias - redirect old module to new module +import agentlab.agents.hint_use_agent as new_module + +sys.modules["agentlab.agents.generic_agent_hinter"] = new_module + +# Re-export everything from the new location +from agentlab.agents.hint_use_agent import * From 02da2db25a7ab6a665999f14d8234e18c3d149f0 Mon Sep 17 00:00:00 2001 From: amanjaiswal73892 Date: Wed, 22 Oct 2025 18:36:05 +0000 Subject: [PATCH 3/8] improve module aliasing for submodules --- .../agents/generic_agent_hinter/__init__.py | 22 ++++++++++--------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/src/agentlab/agents/generic_agent_hinter/__init__.py b/src/agentlab/agents/generic_agent_hinter/__init__.py index 65ab703e..4ad73676 100644 --- a/src/agentlab/agents/generic_agent_hinter/__init__.py +++ b/src/agentlab/agents/generic_agent_hinter/__init__.py @@ -1,17 +1,19 @@ -from agentlab.agents.hint_use_agent import * -import warnings -import sys +import importlib, sys, warnings + +OLD = __name__ +NEW = "agentlab.agents.hint_use_agent" +SUBS = ("agent_configs", "generic_agent_prompt", "generic_agent", "tmlr_config") warnings.warn( - "generic_agent_hinter is renamed to hint_use_agent.", + f"{OLD} is renamed to {NEW}. {OLD} will be removed in future", DeprecationWarning, stacklevel=2, ) -# Create module alias - redirect old module to new module -import agentlab.agents.hint_use_agent as new_module - -sys.modules["agentlab.agents.generic_agent_hinter"] = new_module +# Alias the top-level +new_mod = importlib.import_module(NEW) +sys.modules[OLD] = new_mod -# Re-export everything from the new location -from agentlab.agents.hint_use_agent import * +# Alias known submodules +for sub in SUBS: + sys.modules[f"{OLD}.{sub}"] = importlib.import_module(f"{NEW}.{sub}") From 5eb07620d8525d491e32eb89af702fd7539c8555 Mon Sep 17 00:00:00 2001 From: amanjaiswal73892 Date: Wed, 22 Oct 2025 18:41:32 +0000 Subject: [PATCH 4/8] Add todo rename agent name --- src/agentlab/agents/hint_use_agent/generic_agent.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/agentlab/agents/hint_use_agent/generic_agent.py b/src/agentlab/agents/hint_use_agent/generic_agent.py index 843879f8..27cfd825 100644 --- a/src/agentlab/agents/hint_use_agent/generic_agent.py +++ b/src/agentlab/agents/hint_use_agent/generic_agent.py @@ -39,6 +39,7 @@ class GenericAgentArgs(AgentArgs): def __post_init__(self): try: # some attributes might be temporarily args.CrossProd for hyperparameter generation + #TODO: Rename the agent to HintUseAgent when appropriate self.agent_name = f"GenericAgent-hinter-{self.chat_model_args.model_name}".replace( "/", "_" ) From e2caf090798fe4da294b44883511817457752e75 Mon Sep 17 00:00:00 2001 From: amanjaiswal73892 Date: Wed, 22 Oct 2025 18:44:11 +0000 Subject: [PATCH 5/8] black --- src/agentlab/agents/hint_use_agent/generic_agent.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/agentlab/agents/hint_use_agent/generic_agent.py b/src/agentlab/agents/hint_use_agent/generic_agent.py index 27cfd825..dbc1f094 100644 --- a/src/agentlab/agents/hint_use_agent/generic_agent.py +++ b/src/agentlab/agents/hint_use_agent/generic_agent.py @@ -39,7 +39,7 @@ class GenericAgentArgs(AgentArgs): def __post_init__(self): try: # some attributes might be temporarily args.CrossProd for hyperparameter generation - #TODO: Rename the agent to HintUseAgent when appropriate + # TODO: Rename the agent to HintUseAgent when appropriate self.agent_name = f"GenericAgent-hinter-{self.chat_model_args.model_name}".replace( "/", "_" ) From 1e56d496156538bfff0a6ba64e58fbe985cd52f0 Mon Sep 17 00:00:00 2001 From: amanjaiswal73892 Date: Fri, 24 Oct 2025 22:36:05 +0000 Subject: [PATCH 6/8] bugfix: check for hint_db only when use_task_hint is true. --- src/agentlab/agents/hint_use_agent/generic_agent.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/agentlab/agents/hint_use_agent/generic_agent.py b/src/agentlab/agents/hint_use_agent/generic_agent.py index dbc1f094..fc7192ba 100644 --- a/src/agentlab/agents/hint_use_agent/generic_agent.py +++ b/src/agentlab/agents/hint_use_agent/generic_agent.py @@ -93,7 +93,8 @@ def __init__( self.max_retry = max_retry self.flags = flags - if self.flags.hint_db_path is not None: + + if self.flags.hint_db_path is not None and self.flags.use_task_hint: assert os.path.exists( self.flags.hint_db_path ), f"Hint database path {self.flags.hint_db_path} does not exist." From 85916ecc7921a66416eedec87b0b1b321f924a87 Mon Sep 17 00:00:00 2001 From: amanjaiswal73892 Date: Fri, 24 Oct 2025 22:38:26 +0000 Subject: [PATCH 7/8] fix: address missing initialization and correct args reference in choose_hints method --- src/agentlab/agents/hint_use_agent/generic_agent.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/agentlab/agents/hint_use_agent/generic_agent.py b/src/agentlab/agents/hint_use_agent/generic_agent.py index fc7192ba..b70cc98a 100644 --- a/src/agentlab/agents/hint_use_agent/generic_agent.py +++ b/src/agentlab/agents/hint_use_agent/generic_agent.py @@ -325,7 +325,8 @@ def _get_task_hints(self) -> list[str]: if self.flags.hint_type == "docs": if not hasattr(self, "hint_index"): print("Initializing hint index new time") - self._init() + # @patricebechard It seems _.init() method is missing do we still need it? + # self._init() if self.flags.hint_query_type == "goal": query = self.obs_history[-1]["goal_object"][0]["text"] elif self.flags.hint_query_type == "llm": @@ -333,6 +334,7 @@ def _get_task_hints(self) -> list[str]: # HACK: only 1 query supported query = queries[0] else: + # @patricebechard: This raises an error with the default value 'direct' raise ValueError(f"Unknown hint query type: {self.flags.hint_query_type}") print(f"Query: {query}") @@ -371,7 +373,7 @@ def _get_task_hints(self) -> list[str]: goal_or_queries = "\n".join(self.queries) task_hints = self.hints_source.choose_hints( - self.llm, + self.chat_llm, self.task_name, goal_or_queries, ) From 1a39e392177e7bc29ec762a0d47bab6ce1372a15 Mon Sep 17 00:00:00 2001 From: amanjaiswal73892 Date: Mon, 27 Oct 2025 22:00:29 +0000 Subject: [PATCH 8/8] black --- src/agentlab/agents/hint_use_agent/generic_agent.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/agentlab/agents/hint_use_agent/generic_agent.py b/src/agentlab/agents/hint_use_agent/generic_agent.py index b70cc98a..afc688ed 100644 --- a/src/agentlab/agents/hint_use_agent/generic_agent.py +++ b/src/agentlab/agents/hint_use_agent/generic_agent.py @@ -373,7 +373,7 @@ def _get_task_hints(self) -> list[str]: goal_or_queries = "\n".join(self.queries) task_hints = self.hints_source.choose_hints( - self.chat_llm, + self.chat_llm, self.task_name, goal_or_queries, )