Skip to content

Commit a670f43

Browse files
committed
Set project language to 6 and remove 7+ specifics.
Built ServiceStackIDEA with 1.6 to avoid problems with default OSX install of IntelliJ
1 parent 948db85 commit a670f43

File tree

8 files changed

+122
-231
lines changed

8 files changed

+122
-231
lines changed

src/ServiceStackIDEA/.idea/workspace.xml

Lines changed: 89 additions & 219 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/ServiceStackIDEA/META-INF/plugin.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
]]></description>
1010

1111
<change-notes><![CDATA[
12-
1.0.4 - Bug fixes for Maven project support and new versions of net.servicestack:client
12+
1.0.4 - Bug fixes for Maven project support and new versions of net.servicestack:client.<br />
1313
1.0.3 - Added support to detect Maven pom.xml and inject net.servicestack:client dependency for IntelliJ + Maven modules.<br />
1414
1.0.2 - Fix plugin.xml template bug to enable search from IDE.<br>
1515
1.0 - Initial release.<br />
-70 Bytes
Binary file not shown.

src/ServiceStackIDEA/src/net/servicestack/idea/AddServiceStackRefHandler.java

Lines changed: 22 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public class AddServiceStackRefHandler {
4242

4343
public static void handleOk(String addressUrl, String qualifiedPackageName, String fileName, String selectedDirectory, Module module, StringBuilder errorMessage) {
4444
String url;
45-
List<String> javaCodeLines = new ArrayList<>();
45+
List<String> javaCodeLines = new ArrayList<String>();
4646
try {
4747
URIBuilder urlBuilder = createUrl(addressUrl);
4848
urlBuilder.addParameter("Package", qualifiedPackageName);
@@ -68,7 +68,11 @@ public static void handleOk(String addressUrl, String qualifiedPackageName, Stri
6868
return;
6969
}
7070

71-
} catch (URISyntaxException | MalformedURLException e) {
71+
} catch (URISyntaxException e) {
72+
e.printStackTrace();
73+
errorMessage.append(e.getClass().getName()).append(" - Invalid ServiceStack endpoint provided - ").append(addressUrl);
74+
return;
75+
} catch (MalformedURLException e) {
7276
e.printStackTrace();
7377
errorMessage.append(e.getClass().getName()).append(" - Invalid ServiceStack endpoint provided - ").append(addressUrl);
7478
return;
@@ -80,15 +84,28 @@ public static void handleOk(String addressUrl, String qualifiedPackageName, Stri
8084

8185

8286
GradleBuildFileHelper gradleBuildFileHelper = new GradleBuildFileHelper(module);
83-
boolean showDto;
87+
boolean showDto = true;
8488
final MavenProjectsManager mavenProjectsManager = MavenProjectsManager.getInstance(module.getProject());
8589

8690
boolean isMavenModule = mavenProjectsManager != null && mavenProjectsManager.isMavenizedModule(module);
8791
if(isMavenModule) {
8892
showDto = tryAddMavenDependency(module);
8993
} else {
9094
//Gradle
91-
showDto = addGradleDependencyIfRequired(module,gradleBuildFileHelper);
95+
try {
96+
showDto = addGradleDependencyIfRequired(module,gradleBuildFileHelper);
97+
} catch (FileNotFoundException e) {
98+
e.printStackTrace();
99+
String message = "Failed to update build.gradle with '" +
100+
dependencyGroupId + ":" + clientPackageId + ":" + dependencyVersion +
101+
"'. " + e.getLocalizedMessage();
102+
Notification notification = new Notification(
103+
"ServiceStackIDEA",
104+
"Warning Add ServiceStack Reference",
105+
message,
106+
NotificationType.WARNING);
107+
Notifications.Bus.notify(notification);
108+
}
92109
}
93110

94111
String dtoPath;
@@ -131,7 +148,7 @@ private static boolean tryAddMavenDependency(Module module) {
131148
return showDto;
132149
}
133150

134-
private static boolean addGradleDependencyIfRequired(Module module, GradleBuildFileHelper gradleBuildFileHelper) {
151+
private static boolean addGradleDependencyIfRequired(Module module, GradleBuildFileHelper gradleBuildFileHelper) throws FileNotFoundException {
135152
boolean result = true;
136153
if(gradleBuildFileHelper.addDependency(dependencyGroupId, dependencyPackageId, dependencyVersion)) {
137154
result = false;

src/ServiceStackIDEA/src/net/servicestack/idea/AddServiceStackReference.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public void actionPerformed(AnActionEvent e) {
5858
PsiDirectory selectedDir = (PsiDirectory) element;
5959
String packageName = "";
6060
String moduleDirectoryPath = module.getModuleFile().getParent().getPath();
61-
List<String> packageArray = new ArrayList<>();
61+
List<String> packageArray = new ArrayList<String>();
6262
while (selectedDir != null && !(Objects.equals(moduleDirectoryPath, selectedDir.getVirtualFile().getPath()))) {
6363
packageArray.add(selectedDir.getName());
6464
selectedDir = selectedDir.getParent();

src/ServiceStackIDEA/src/net/servicestack/idea/GradleBuildFileHelper.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public GradleBuildFileHelper(Module module) {
1919
this.module = module;
2020
}
2121

22-
public boolean addDependency(String groupId, String packageName, String version) {
22+
public boolean addDependency(String groupId, String packageName, String version) throws FileNotFoundException {
2323
VirtualFile moduleFile = module.getModuleFile();
2424
if(moduleFile == null) {
2525
return false;
@@ -39,8 +39,9 @@ public boolean accept(File dir, String name) {
3939
File gradleFile = matchingFiles[0];
4040
Integer dependenciesStartIndex = -1;
4141
Integer dependenciesEndIndex = -1;
42-
List<String> list = new ArrayList<>();
43-
try (BufferedReader br = new BufferedReader(new FileReader(gradleFile))) {
42+
List<String> list = new ArrayList<String>();
43+
BufferedReader br = new BufferedReader(new FileReader(gradleFile));
44+
try {
4445
int count = 0;
4546
for(String line; (line = br.readLine()) != null; ) {
4647
list.add(line);

src/ServiceStackIDEA/src/net/servicestack/idea/IDEAPomFileHelper.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,10 @@ public boolean addMavenDependencyIfRequired(File pomFile, String groupId, String
4747
noDependencyAdded = false;
4848
}
4949

50-
} catch (IOException | XmlPullParserException e) {
50+
} catch (IOException e) {
51+
e.printStackTrace();
52+
throw new Exception("Unable to process pom.xml to add " + groupId + ":" + packageId + ":" + version);
53+
} catch (XmlPullParserException e) {
5154
e.printStackTrace();
5255
throw new Exception("Unable to process pom.xml to add " + groupId + ":" + packageId + ":" + version);
5356
}

src/ServiceStackIDEA/src/net/servicestack/idea/UpdateServiceStackUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ public class UpdateServiceStackUtils {
2828
public static void updateServiceStackReference(PsiFile psiFile) {
2929
String code = psiFile.getText();
3030
Scanner scanner = new Scanner(code);
31-
List<String> linesOfCode = new ArrayList<>();
31+
List<String> linesOfCode = new ArrayList<String>();
3232
while (scanner.hasNextLine()) {
3333
String line = scanner.nextLine();
3434
linesOfCode.add(line);

0 commit comments

Comments
 (0)