Fix for parsing static method inside non-static method. (#616)

* Support for Conditional expression in filter

* Fixes for conditional expressions in filter and sorting

* Using GetFieldValue in InsertOnly just like in Insert.

* Change SqliteBoolConverter DbType to Int32

* Unit test for SqliteBoolConverter, InsertOnly

* Fix for parsing static method inside non-static method.

* Just formatting

* Change access modifier to public for method "IsSqlClass"

Author: OlegNadymov

src/ServiceStack.OrmLite/Expressions/SqlExpression.cs

@@ -794,7 +794,7 @@ private SqlExpression<T> OrderByInternal(Expression keySelector)
             return this;
         }
 
-        private static bool IsSqlClass(object obj)
+        public static bool IsSqlClass(object obj)
         {
             return obj != null &&
                    (obj is PartialSqlString ||
@@ -2104,7 +2104,18 @@ private object GetNotValue(object o)
         protected virtual bool IsColumnAccess(MethodCallExpression m)
         {
             if (m.Object == null)
+            {
+                foreach (var arg in m.Arguments)
+                {
+                    if (!(arg is LambdaExpression) &&
+                        IsParameterAccess(arg))
+                    {
+                        return true;
+                    }
+                }
+
                 return false;
+            }
 
             if (m.Object is MethodCallExpression methCallExp)
                 return IsColumnAccess(methCallExp);
@@ -2131,12 +2142,12 @@ protected virtual object VisitMethodCall(MethodCallExpression m)
             if (IsEnumerableMethod(m))
                 return VisitEnumerableMethodCall(m);
 
-            if (IsColumnAccess(m))
-                return VisitColumnAccessMethod(m);
-
             if (IsStaticStringMethod(m))
                 return VisitStaticStringMethodCall(m);
 
+            if (IsColumnAccess(m))
+                return VisitColumnAccessMethod(m);
+
             return EvaluateExpression(m);
         }
 

tests/ServiceStack.OrmLite.Tests/ExpressionVisitorTests.cs

@@ -861,6 +861,19 @@ public void Can_Where_using_Constant_in_Conditional_order7()
             Assert.AreEqual("asdf", text);
         }
 
+        [Test]
+        public void Can_Where_using_StaticInsideNonStaticMethod()
+        {
+            System.Linq.Expressions.Expression<Func<TestType, bool>> filter = x => String.Concat(x.TextCol, "test").StartsWith("asdf");
+            var q = Db.From<TestType>().Where(filter).OrderBy(x => x.Id);
+            Assert.That(q.ToSelectStatement().ToLower(), Does.Not.Contain(SqlExpression<TestType>.TrueLiteral));
+
+            var target = Db.Select(q);
+            Assert.That(target.Count, Is.EqualTo(2));
+            var text = target[0].TextCol;
+            Assert.AreEqual("asdf", text);
+        }
+
         private int MethodReturningInt(int val)
         {
             return val;