Merge pull request #582 from OlegNadymov/master

Fix for visiting constants inside VisitInSqlExpressionList

Author: mythz

src/ServiceStack.OrmLite/Expressions/SqlExpression.cs

@@ -1907,7 +1907,7 @@ protected virtual List<object> VisitInSqlExpressionList(ReadOnlyCollection<Expre
                 }
                 else if (e.NodeType == ExpressionType.MemberAccess)
                 {
-                    list.Add(GetMemberExpression(e as MemberExpression));
+                    list.Add(VisitMemberAccess(e as MemberExpression));
                 }
                 else
                 {
@@ -1980,7 +1980,7 @@ protected virtual string GetQuotedColumnName(ModelDefinition tableDef, string me
                     ? fd.FieldName
                     : memberName;
 
-                var includePrefix = PrefixFieldWithTableName && fd.CustomSelect == null;
+                var includePrefix = PrefixFieldWithTableName && fd?.CustomSelect == null;
                 return includePrefix
                     ? DialectProvider.GetQuotedColumnName(tableDef, fieldName)
                     : DialectProvider.GetQuotedColumnName(fieldName);

tests/ServiceStack.OrmLite.Tests/ExpressionVisitorTests.cs

@@ -552,6 +552,18 @@ public void Can_Where_using_Bool_Constant_Conditional_filter()
             Assert.That(target.Count, Is.EqualTo(1));
         }
 
+        [Test]
+        public void Can_Where_using_SqlIn_filter()
+        {
+            var subQ = Db.From<TestType>().Where(x=>x.NullableIntCol == 10).Select(x=>x.Id);
+            var q = Db.From<TestType>();
+            q.PrefixFieldWithTableName = true;
+            q.Where(x=>Sql.In(x.Id, subQ));
+
+            var target = Db.Select(q);
+            Assert.That(target.Count, Is.EqualTo(1));
+        }
+
         private int MethodReturningInt(int val)
         {
             return val;