Merge pull request #496 from BruceCowan-AI/FixStringConverter

Fix Oracle string converter and one test

Author: mythz

src/ServiceStack.OrmLite.Oracle/Converters/OracleStringConverters.cs

@@ -5,17 +5,18 @@ namespace ServiceStack.OrmLite.Oracle.Converters
 {
     public class OracleStringConverter : StringConverter
     {
-        public OracleStringConverter() : base(4000) {}
+        public OracleStringConverter() : base(2000) {}
         public OracleStringConverter(int stringLength) : base(stringLength) {}
 
         public override string MaxColumnDefinition
         {
-            get { return GetColumnDefinition(4000); }
+            get { return GetColumnDefinition(2000); }
         }
 
         public override string GetColumnDefinition(int? stringLength)
         {
-            var safeLength = Math.Min(stringLength.GetValueOrDefault(StringLength), 4000);
+            var maxLength = UseUnicode ? 2000 : 4000;
+            var safeLength = Math.Min(stringLength.GetValueOrDefault(StringLength), maxLength);
             return UseUnicode
                 ? "NVARCHAR2({0})".Fmt(safeLength)
                 : "VARCHAR2({0})".Fmt(safeLength);

tests/ServiceStack.OrmLite.Tests/OrmLiteUpdateTests.cs

@@ -310,7 +310,8 @@ public void Can_updated_with_ExecuteSql_and_db_params()
                 db.Insert(new Poco { Id = 1, Name = "A" });
                 db.Insert(new Poco { Id = 2, Name = "B" });
 
-                var result = db.ExecuteSql("UPDATE poco SET name = @name WHERE id = @id", new { id = 2, name = "UPDATED" });
+                var sql = "UPDATE poco SET name = {0}name WHERE id = {0}id".Fmt(OrmLiteConfig.DialectProvider.ParamString);
+                var result = db.ExecuteSql(sql, new { id = 2, name = "UPDATED" });
                 Assert.That(result, Is.EqualTo(1));
 
                 var row = db.SingleById<Poco>(2);