Switched out Linq.Contains() in favor of Array.IndexOf()

Dusty Kline · Dusty Kline · commit 6cbcd336eaac · 2015-06-09T17:14:29.000-05:00
diff --git a/src/ServiceStack.Text/Common/ParseUtils.cs b/src/ServiceStack.Text/Common/ParseUtils.cs
@@ -11,7 +11,6 @@
 //
 
 using System;
-using System.Linq;
 
 namespace ServiceStack.Text.Common
 {
@@ -67,10 +66,9 @@ public static object TryParseEnum(Type enumType, string str)
             if (JsConfig.EmitLowercaseUnderscoreNames)
             {
                 string[] names = Enum.GetNames(enumType);
-                if (!names.Contains(str))   // does this need StringComparer.InvariantCultureIgnoreCase?
+                if (Array.IndexOf(names, str) == -1)    // case sensitive ... could use Linq Contains() extension with StringComparer.InvariantCultureIgnoreCase instead for a slight penalty
                     str = str.Replace("_", "");
             }
-                
 
             return Enum.Parse(enumType, str, ignoreCase: true);
         }

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,6 @@`
`11`	`11`	`//`
`12`	`12`
`13`	`13`	`using System;`
`14`		`-using System.Linq;`
`15`	`14`
`16`	`15`	`namespace ServiceStack.Text.Common`
`17`	`16`	`{`
`@@ -67,10 +66,9 @@ public static object TryParseEnum(Type enumType, string str)`
`67`	`66`	`if (JsConfig.EmitLowercaseUnderscoreNames)`
`68`	`67`	`{`
`69`	`68`	`string[] names = Enum.GetNames(enumType);`
`70`		`- if (!names.Contains(str)) // does this need StringComparer.InvariantCultureIgnoreCase?`
	`69`	`+ if (Array.IndexOf(names, str) == -1) // case sensitive ... could use Linq Contains() extension with StringComparer.InvariantCultureIgnoreCase instead for a slight penalty`
`71`	`70`	`str = str.Replace("_", "");`
`72`	`71`	`}`
`73`		`-`
`74`	`72`
`75`	`73`	`return Enum.Parse(enumType, str, ignoreCase: true);`
`76`	`74`	`}`