Only return instance properties in PCL GetPublicProperties

Author: mythz

src/ServiceStack.Text/ReflectionExtensions.cs

@@ -834,7 +834,14 @@ public static ConstructorInfo GetEmptyConstructor(this Type type)
         internal static PropertyInfo[] GetTypesPublicProperties(this Type subType)
         {
 #if (NETFX_CORE || PCL)
-            return subType.GetRuntimeProperties().ToArray();
+            var pis = new List<PropertyInfo>();
+            foreach (var pi in subType.GetRuntimeProperties())
+            {
+                var mi = pi.GetMethod ?? pi.SetMethod;
+                if (mi != null && mi.IsStatic) continue;
+                pis.Add(pi);
+            }
+            return pis.ToArray();
 #else
             return subType.GetProperties(
                 BindingFlags.FlattenHierarchy |

tests/ServiceStack.Text.Tests/JsonTests/JsonEnumTests.cs

@@ -0,0 +1,53 @@
+using System;
+using NUnit.Framework;
+
+namespace ServiceStack.Text.Tests.JsonTests
+{
+    [Flags]
+    public enum DbModelComparisonTypesEnum : int
+    {
+        /// <summary>
+        /// Compare only the PrimaryKey values
+        /// </summary>
+        PkOnly = 1,
+        /// <summary>
+        /// Compare only the non PrimaryKey values
+        /// </summary>
+        NonPkOnly = 2,
+        /// <summary>
+        /// Compare all values
+        /// (The PrimaryKey and non PrimaryKey values too)
+        /// </summary>
+        All = 3 // PkOnly & NonPkOnly
+    }
+
+    public partial class Question
+    {
+        public static DbModelComparisonTypesEnum DefaultComparisonType { get; set; }
+
+        public Guid Id { get; set; }
+        public string Title { get; set; }
+    }
+    
+    [TestFixture]
+    public class JsonEnumTests
+    {
+        [Test]
+        public void Can_serialize_dto_with_static_enum()
+        {
+            Question.DefaultComparisonType = DbModelComparisonTypesEnum.All;
+
+            var dto = new Question
+            {
+                Id = Guid.NewGuid(),
+                Title = "Title",
+            };
+
+            var json = dto.ToJson();
+            var q = json.FromJson<Question>();
+
+            Assert.That(q.Id, Is.EqualTo(dto.Id));
+            Assert.That(q.Title, Is.EqualTo(dto.Title));
+        }
+    }
+}

tests/ServiceStack.Text.Tests/ServiceStack.Text.Tests.csproj

@@ -177,6 +177,7 @@
   </ItemGroup>
   <ItemGroup>
     <Compile Include="AttributeTests.cs" />
+    <Compile Include="JsonTests\JsonEnumTests.cs" />
     <Compile Include="JsonTests\InvalidJsonTests.cs" />
     <Compile Include="JsonTests\TypeInfoTests.cs" />
     <Compile Include="SerializationDelegatePerformanceTests.cs" />
@@ -352,6 +353,7 @@
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>
   </ItemGroup>
+  <ItemGroup />
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <Import Project="$(SolutionDir)\.nuget\NuGet.targets" />
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it.