Skip to content

VanillaModelEncoder#emitItemQuads does not respect Forge/NeoForge model extensions #186

@PepperCode1

Description

@PepperCode1

NeoForge patches the ItemRenderer to respect IBakedModelExtension#getRenderPasses(ItemStack, boolean) and IBakedModelExtension#getRenderTypes(ItemStack, boolean): https://github.com/neoforged/NeoForge/blob/1.21.1/patches/net/minecraft/client/renderer/entity/ItemRenderer.java.patch#L26-L27.

Neither of these methods are ever called in either Forgified FRAPI or Forgified Indigo, which leads to severe issues like crashes and missing visuals. Calling them in VanillaModelEncoder#emitItemQuads would be the best solution, but would need additional work as FRAPI does not accept RenderTypes directly; this method would need to be moved to Forgified Indigo so it can provide the RenderTypes directly. Inspection of quads with a non-standard RenderType could result in BlendMode.DEFAULT.

Metadata

Metadata

Assignees

No one assigned

    Labels

    1.21.xTargets Minecraft 1.21help wantedExtra attention is needed

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions