Fix regression on download and install lib on usage.

Author: jan

io.sloeber.core/src/io/sloeber/arduinoFramework/api/LibraryManager.java

@@ -142,6 +142,7 @@ public static void installLibrary(String libName) {
 		}
 	}
 
+
 	public static IStatus install(IArduinoLibraryVersion inLib, IProgressMonitor monitor) {
 		if (!(inLib instanceof ArduinoLibraryVersion)) {
 			return Status.error("Trying to install a library that is not a installable library" + inLib.getName()); //$NON-NLS-1$
@@ -470,4 +471,22 @@ public static IArduinoLibraryVersion getLibraryVersionFromLocation(IFolder libFo
 		return getLibrariesPrivate().get(libFolder.getName());
 	}
 
+	/**
+	 * Remove a lib based on the name of the lib
+	 *
+	 * @param libName the name of the lib
+	 * @return true if the lib has been removed or was not found
+	 *          false if the lib was found and the removal failed.
+	 */
+	public static boolean uninstallLibrary(String libName) {
+		Map<String, IArduinoLibraryVersion> installedLibs=getLibrariesAll(null);
+		IPath libFQN=ArduinoLibraryVersion.calculateFQN(libName);
+		IArduinoLibraryVersion libVersion = installedLibs.get(libFQN.toString());
+		if(libVersion==null) {
+			return true;
+
+		}
+		return unInstall(libVersion, new NullProgressMonitor()).isOK();
+	}
+
 }

io.sloeber.core/src/io/sloeber/core/api/ConfigurationPreferences.java

@@ -250,4 +250,21 @@ private static Duration getDuration(String key, Duration defaultValue) {
 		return Duration.ofDays(ret);
 	}
 
+	/**
+	 * Allow the library manager to download and install libraries based on include directive in the source code.
+	 *
+	 * @param selection true if you want to install libraries based on their usage else false
+	 */
+	public static void setInstallLibraries(boolean selection) {
+		InstancePreferences.setInstallLibraries(selection);
+	}
+
+	/**
+	 *
+	 * @return true when libraries can be downloaded and installed when referenced in the code.
+	 */
+	public static boolean getInstallLibraries() {
+		return  InstancePreferences.getInstallLibraries();
+	}
+
 }

io.sloeber.core/src/io/sloeber/core/api/Defaults.java

@@ -36,6 +36,7 @@ public class Defaults {
     public static final boolean useBonjour = true;
     public static final boolean autoInstallLibraries = true;
     public static final boolean useArduinoToolSelection = true;
+	public static final boolean INSTALL_LIBRARIES =false; //Install libraries on usage
 
     /**
      * Arduino has the default libraries in the user home directory in subfolder

io.sloeber.core/src/io/sloeber/core/common/InstancePreferences.java

@@ -28,6 +28,7 @@ public class InstancePreferences {
 	private static final String KEY_PRAGMA_ONCE_HEADER = "add pragma once to headers"; //$NON-NLS-1$
 	private static final String KEY_USE_ARDUINO_TOOLS_SELECTION_ALGORITHM="Use the algoritm to find the toolchain like Arduino IDE"; //$NON-NLS-1$
 	private static final String KEY_USE_BONJOUR="use bonjour service to find devices"; //$NON-NLS-1$
+	private static final String KEY_INSTALL_LIBRARIES= "download and install libraries on usage"; //$NON-NLS-1$
 
 	/**
 	 * Give back the user option if the libraries need to be added or not
@@ -141,4 +142,12 @@ public static boolean useBonjour() {
 	public static void setUseBonjour(boolean newFlag) {
 		setValue(KEY_USE_BONJOUR, newFlag);
 	}
+
+	public static void setInstallLibraries(boolean selection) {
+		setValue(KEY_INSTALL_LIBRARIES, selection);
+	}
+
+	public static boolean getInstallLibraries() {
+		return getBoolean(KEY_INSTALL_LIBRARIES, Defaults.INSTALL_LIBRARIES);
+	}
 }

io.sloeber.core/src/io/sloeber/core/listeners/IndexerListener.java

@@ -35,6 +35,7 @@
 import io.sloeber.arduinoFramework.api.LibraryManager;
 import io.sloeber.core.Activator;
 import io.sloeber.core.Messages;
+import io.sloeber.core.api.ConfigurationPreferences;
 import io.sloeber.core.api.Const;
 import io.sloeber.core.api.IInstallLibraryHandler;
 import io.sloeber.core.api.ISloeberConfiguration;
@@ -124,7 +125,7 @@ private static void checkLibraries(ISloeberConfiguration SloeberCfg) {
 
 		//Check wether we need to download and install libraries
 		IInstallLibraryHandler installHandler = LibraryManager.getInstallLibraryHandler();
-		if (installHandler.autoInstall()) {
+		if (ConfigurationPreferences.getInstallLibraries() && installHandler.autoInstall()) {
 			// Check if there are libraries that are not found in
 			// the installed libraries
 			Set<String> uninstalledIncludedHeaders = new TreeSet<>(UnresolvedIncludedHeaders);

io.sloeber.ui/src/io/sloeber/ui/preferences/PreferencePage.java

@@ -69,23 +69,23 @@ public class PreferencePage extends FieldEditorPreferencePage implements IWorkbe
 	private static final String KEY_PRIVATE_HARDWARE_PATHS = "Gui entry for private hardware paths"; //$NON-NLS-1$
 	private static final String KEY_PRIVATE_LIBRARY_PATHS = "Gui entry for private library paths"; //$NON-NLS-1$
 	private static final String KEY_TOOLCHAIN_SELECTION = "Gui entry for toolchain selection"; //$NON-NLS-1$
-	//private static final String KEY_USE_BONJOUR = "Gui entry for usage of bonjour"; //$NON-NLS-1$
+
 
 	private PathEditor arduinoPrivateLibPathPathEditor;
 	private PathEditor arduinoPrivateHardwarePathPathEditor;
 	private ComboFieldEditor buildBeforeUploadOptionEditor;
 	private BooleanFieldEditor openSerialMonitorOpensSerialsOptionEditor;
 	private BooleanFieldEditor automaticallyImportLibrariesOptionEditor;
-	//private BooleanFieldEditor automaticallyInstallLibrariesOptionEditor;
 	private BooleanFieldEditor useArduinoToolchainSelectionEditor;
 	private BooleanFieldEditor pragmaOnceHeaderOptionEditor;
 	private BooleanFieldEditor cleanSerialMonitorAfterUploadEditor;
 	private BooleanFieldEditor switchToSerialMonitorAfterUploadEditor;
 	private BooleanFieldEditor enableParallelBuildForNewProjects;
-	//private BooleanFieldEditor enableBonjour;
+
 	private Button myBonjourCheckBox;
 	private Spinner myDelayNumberSpinner;
 	private Combo myDelayUnitCombo;
+	private Button myInstallLibCheckBox;
 
 	private static int[] durationUnits = new int[] { 1, 7, 30, 365, 36500 };
 
@@ -154,6 +154,8 @@ public boolean performOk() {
         ConfigurationPreferences.setAutoImportLibraries(this.automaticallyImportLibrariesOptionEditor.getBooleanValue());
         ConfigurationPreferences.setPragmaOnceHeaders(this.pragmaOnceHeaderOptionEditor.getBooleanValue());
         ConfigurationPreferences.setUseBonjour(myBonjourCheckBox.getSelection());
+        ConfigurationPreferences.setInstallLibraries(myInstallLibCheckBox.getSelection());
+
         //TOFIX line below
         ConfigurationPreferences.setJsonUpdateDelay(Duration.ofDays(myDelayNumberSpinner.getSelection() * durationUnits[myDelayUnitCombo.getSelectionIndex()]));
 		BoardsManager.setPrivateHardwarePaths(hardWarePaths);
@@ -321,12 +323,12 @@ protected void createFieldEditors() {
 		Dialog.applyDialogFont(netWorkbox);
 
 		//Currently sloeber does not autoinstall librtaries
-//		Button myInstallLibCheckBox = new Button(netWorkbox, SWT.CHECK | SWT.LEFT);
-//		Label inStallLabel = new Label(netWorkbox, SWT.BEGINNING);
-//		inStallLabel.setText(Messages.ui_auto_install_libraries);
-//		GridData gd16 = new GridData(SWT.BEGINNING, SWT.TOP, true, false);
-//		gd16.horizontalSpan=3;
-//		inStallLabel.setLayoutData(gd16);
+		myInstallLibCheckBox = new Button(netWorkbox, SWT.CHECK | SWT.LEFT);
+		Label inStallLabel = new Label(netWorkbox, SWT.BEGINNING);
+		inStallLabel.setText(Messages.ui_auto_install_libraries);
+		GridData gd16 = new GridData(SWT.BEGINNING, SWT.TOP, true, false);
+		gd16.horizontalSpan=3;
+		inStallLabel.setLayoutData(gd16);
 
 
 		myBonjourCheckBox = new Button(netWorkbox, SWT.CHECK | SWT.LEFT );
@@ -374,6 +376,7 @@ public void widgetDefaultSelected(SelectionEvent e) {
 
 
 		myBonjourCheckBox.setSelection(ConfigurationPreferences.useBonjour());
+		myInstallLibCheckBox.setSelection(ConfigurationPreferences.getInstallLibraries());
 		setJsonDurationComposites(ConfigurationPreferences.getJsonUpdateDelay());
 
 	}
@@ -412,6 +415,7 @@ protected void performApply() {
 	protected void performDefaults() {
 		super.performDefaults();
 		myBonjourCheckBox.setSelection( Defaults.useBonjour);
+		myInstallLibCheckBox.setSelection( Defaults.INSTALL_LIBRARIES);
 		setJsonDurationComposites(Defaults.getJsonUpdateDuration());
 
 	}