Do not install deprecated platforms during testing

Author: jantje

io.sloeber.core/src/io/sloeber/core/api/BoardsManager.java

@@ -162,6 +162,7 @@ public static void setPackageURLs(HashSet<String> packageUrls, boolean forceDown
      *            the platforms after this platform are skipped
      */
     public static void installsubsetOfLatestPlatforms(int fromIndex, int toIndex) {
+        String DEPRECATED = "DEPRECATED"; //$NON-NLS-1$
         if (!isReady()) {
             Common.log(new Status(IStatus.ERROR, Const.CORE_PLUGIN_ID, BoardsManagerIsBussy, new Exception()));
             return;
@@ -173,11 +174,21 @@ public static void installsubsetOfLatestPlatforms(int fromIndex, int toIndex) {
         for (ArduinoPackage curPackage : allPackages) {
             Collection<ArduinoPlatform> latestPlatforms = curPackage.getPlatforms();
             for (ArduinoPlatform curPlatform : latestPlatforms) {
-                if (currPlatformIndex > fromIndex) {
-                    install(curPlatform.getNewestVersion(), monitor);
+                if (!curPlatform.getName().toUpperCase().contains(DEPRECATED)) {
+                    if (currPlatformIndex > fromIndex) {
+                        ArduinoPlatformVersion latestPlatformVersion = curPlatform.getNewestVersion();
+                        if (!latestPlatformVersion.getName().toUpperCase().contains(DEPRECATED)) {
+                            install(latestPlatformVersion, monitor);
+                        } else {
+                            System.out.println("skipping platform " + latestPlatformVersion.toString()); //$NON-NLS-1$
+                        }
+                    }
+                    if (currPlatformIndex++ > toIndex) {
+                        return;
+                    }
+                } else {
+                    System.out.println("skipping platform " + curPlatform.toString()); //$NON-NLS-1$
                 }
-                if (currPlatformIndex++ > toIndex)
-                    return;
             }
         }
     }
@@ -219,12 +230,12 @@ private static IStatus install(ArduinoPlatformVersion platformVersion, IProgress
         String version = platformVersion.getVersion().toString();
         // Check if we're installed already
         if (platformVersion.isInstalled()) {
-            System.out.println("reusing platform " + name + " " + architecture + "(" + version + ")"); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$
+            System.out.println("reusing platform " + platformVersion.toString()); //$NON-NLS-1$
             return Status.OK_STATUS;
         }
 
         // Download platform archive
-        System.out.println("start installing platform " + name + " " + architecture + "(" + version + ")"); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$
+        System.out.println("start installing platform " + platformVersion.toString()); //$NON-NLS-1$
 
         MyMultiStatus mstatus = new MyMultiStatus("Failed to install " + platformVersion.getName()); //$NON-NLS-1$
         mstatus.addErrors(PackageManager.downloadAndInstall(platformVersion, forceDownload, monitor));
@@ -269,7 +280,7 @@ private static IStatus install(ArduinoPlatformVersion platformVersion, IProgress
 
         WorkAround.applyKnownWorkArounds(platformVersion);
 
-        System.out.println("done installing platform " + name + " " + architecture + "(" + version + ")"); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$ //$NON-NLS-4$
+        System.out.println("done installing platform " + platformVersion.toString()); //$NON-NLS-1$ 
         return mstatus;
     }
 

io.sloeber.core/src/io/sloeber/core/api/Json/ArduinoPlatform.java

@@ -8,6 +8,7 @@
 package io.sloeber.core.api.Json;
 
 import static io.sloeber.core.Gson.GsonConverter.*;
+import static io.sloeber.core.common.Const.*;
 
 import java.util.Collection;
 import java.util.Collections;
@@ -115,4 +116,8 @@ public ArduinoPlatformVersion getNewestInstalled() {
         return null;
     }
 
+    @Override
+    public String toString() {
+        return name + SPACE + architecture;
+    }
 }

io.sloeber.core/src/io/sloeber/core/api/Json/ArduinoPlatformVersion.java

@@ -21,7 +21,7 @@
 import com.google.gson.JsonParseException;
 
 import io.sloeber.core.api.VersionNumber;
-import io.sloeber.core.common.Const;
+import static io.sloeber.core.common.Const.*;
 
 public class ArduinoPlatformVersion extends ArduinoInstallable implements Comparable<ArduinoPlatformVersion> {
 
@@ -86,11 +86,11 @@ public boolean isInstalled() {
     }
 
     public File getBoardsFile() {
-        return getInstallPath().append(Const.BOARDS_FILE_NAME).toFile();
+        return getInstallPath().append(BOARDS_FILE_NAME).toFile();
     }
 
     public File getPlatformFile() {
-        return getInstallPath().append(Const.PLATFORM_FILE_NAME).toFile();
+        return getInstallPath().append(PLATFORM_FILE_NAME).toFile();
     }
 
     @Override
@@ -101,7 +101,7 @@ public IPath getInstallPath() {
     public List<IPath> getIncludePath() {
         IPath installPath = getInstallPath();
         return Arrays.asList(installPath.append("cores/{build.core}"), //$NON-NLS-1$
-                installPath.append(Const.VARIANTS_FOLDER_NAME + "/{build.variant}")); //$NON-NLS-1$
+                installPath.append(VARIANTS_FOLDER_NAME + "/{build.variant}")); //$NON-NLS-1$
     }
 
     @Override
@@ -158,4 +158,9 @@ public int compareTo(ArduinoPlatformVersion o) {
         return name.compareTo(o.getName());
     }
 
+    @Override
+    public String toString() {
+        return name + SPACE + architecture + '(' + version + ')';
+    }
+
 }

io.sloeber.core/src/io/sloeber/core/common/Const.java

@@ -25,6 +25,7 @@ public class Const {
     public static final String EMPTY = "";
     public static final String NEWLINE = "\n";
     public static final String EQUAL = "=";
+    public static final String SPACE = " ";
 
     // arduino txt basic keys
     public static final String VARIANT = "variant";