Unit tests now skip boards that are marked as non visble

Author: jantje

io.sloeber.core/src/io/sloeber/core/Activator.java

@@ -75,6 +75,7 @@ public class Activator extends AbstractUIPlugin {
 			'e', 'c', 'l', 'i', 'p', 's', 'e', '/', 'd', 'o', 'w', 'n', 'l', 'o', 'a', 'd', '/', 'p', 'l', 'u', 'g',
 			'i', 'n', 'S', 't', 'a', 'r', 't', '.', 'h', 't', 'm', 'l', '?', 's', '=' };
 	private static final String PLUGIN_ID = "io.sloeber.core";
+	private static Boolean isPatron = null;
 
 	@Override
 	public void start(BundleContext context) throws Exception {
@@ -375,7 +376,7 @@ protected IStatus run(IProgressMonitor monitor) {
 					} catch (BackingStoreException e) {
 						// this should not happen
 					}
-					if (isInternetReachable()) {
+					if (!isPatron()) {
 						PleaseHelp.doHelp(HELP_LOC);
 					}
 				}
@@ -387,17 +388,15 @@ protected IStatus run(IProgressMonitor monitor) {
 		job.schedule(60000);
 	}
 
-	static boolean isInternetReachable() {
-		boolean ret = false;
+	static boolean isPatron() {
+		if (isPatron != null) {
+			return isPatron.booleanValue();
+		}
 		HttpURLConnection urlConnect = null;
-
 		try {
-			// make a URL to a known source
-			URL url = new URL(HELP_LOC + "?systemhash=" + ConfigurationPreferences.getSystemHash());
-			// open a connection to that source
+			String systemhash = ConfigurationPreferences.getSystemHash();
+			URL url = new URL(HELP_LOC + "?systemhash=" + systemhash);
 			urlConnect = (HttpURLConnection) url.openConnection();
-			// trying to retrieve data from the source. If there is no
-			// connection, this line will fail
 			urlConnect.getContent();
 		} catch (UnknownHostException e) {
 			return false;
@@ -406,14 +405,19 @@ static boolean isInternetReachable() {
 		} finally {
 			if (urlConnect != null) {
 				try {
-					ret = (urlConnect.getResponseCode() != 404);
+					urlConnect.getContent();
 				} catch (IOException e) {
-					// ignore
+					// TODO Auto-generated catch block
+					e.printStackTrace();
 				}
+				int length = urlConnect.getContentLength();
+				isPatron = new Boolean(length < 200);
 				urlConnect.disconnect();
 			}
-
 		}
-		return ret;
+		if (isPatron != null) {
+			return isPatron.booleanValue();
+		}
+		return false;
 	}
 }

io.sloeber.core/src/io/sloeber/core/api/BoardDescriptor.java

@@ -211,9 +211,11 @@ public static List<BoardDescriptor> makeBoardDescriptors(File boardFile) {
 		TxtFile txtFile = new TxtFile(boardFile);
 		List<BoardDescriptor> boards = new ArrayList<>();
 		for (String curboardName : txtFile.getAllNames()) {
-			Map<String, String> boardSection = txtFile.getSection(curboardName);
-			if (!"true".equalsIgnoreCase(boardSection.get("hide"))) {
-				boards.add(makeBoardDescriptor(boardFile, txtFile.getBoardIDFromBoardName(curboardName), null));
+			Map<String, String> boardSection = txtFile.getSection(txtFile.getBoardIDFromBoardName(curboardName));
+			if (boardSection != null) {
+				if (!"true".equalsIgnoreCase(boardSection.get("hide"))) {
+					boards.add(makeBoardDescriptor(boardFile, txtFile.getBoardIDFromBoardName(curboardName), null));
+				}
 			}
 		}
 		return boards;

io.sloeber.core/src/jUnit/CreateAndCompileExamples.java

@@ -17,7 +17,6 @@
 import org.eclipse.core.runtime.IPath;
 import org.eclipse.core.runtime.NullProgressMonitor;
 import org.eclipse.core.runtime.Path;
-import org.junit.BeforeClass;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.Parameterized;
@@ -45,6 +44,7 @@ public CreateAndCompileExamples(String name, BoardDescriptor boardid, CodeDescri
 	@SuppressWarnings("rawtypes")
 	@Parameters(name = "{index}: {0}")
 	public static Collection examples() {
+		WaitForInstallerToFinish();
 		Map<String, String> myOptions = new HashMap<>();
 		String[] lines = new String("").split("\n"); //$NON-NLS-1$
 		for (String curLine : lines) {
@@ -60,15 +60,15 @@ public static Collection examples() {
 			return null;
 		}
 		leonardoBoardid.setUploadPort("none");
-		BoardDescriptor unoBoardid = BoardsManager.getBoardDescriptor("package_index.json", "arduino", "Arduino AVR Boards",
-				"uno", myOptions);
+		BoardDescriptor unoBoardid = BoardsManager.getBoardDescriptor("package_index.json", "arduino",
+				"Arduino AVR Boards", "uno", myOptions);
 		if (unoBoardid == null) {
 			fail("uno Board not found");
 			return null;
 		}
 		unoBoardid.setUploadPort("none");
-		BoardDescriptor EsploraBoardid = BoardsManager.getBoardDescriptor("package_index.json", "arduino", "Arduino AVR Boards",
-				"esplora", myOptions);
+		BoardDescriptor EsploraBoardid = BoardsManager.getBoardDescriptor("package_index.json", "arduino",
+				"Arduino AVR Boards", "esplora", myOptions);
 		if (EsploraBoardid == null) {
 			fail("Esplora Board not found");
 			return null;
@@ -150,7 +150,7 @@ private static boolean isExampleOkForEsplora(String key) {
 	 * installer job will trigger downloads These mmust have finished before we
 	 * can start testing
 	 */
-	@BeforeClass
+
 	public static void WaitForInstallerToFinish() {
 		installAdditionalBoards();
 		Shared.waitForAllJobsToFinish();

website/WebContent/remind.php

@@ -14,7 +14,7 @@
 
 			if ($result->num_rows > 0) {
 				$default = 0;
-				header ( $_SERVER ["SERVER_PROTOCOL"] . " 404 Not Found", true, 404 );
+				echo $secretMessage;
 				// output data of each row
 				while ( $row = $result->fetch_assoc () ) {
 					echo "Patron: " . $row ["patronIDE"] . " key:" . $KEY . "<br>";