more error logging

Author: jan

io.sloeber.core/src/io/sloeber/core/managers/WorkAround.java

@@ -120,8 +120,9 @@ static public File MakeBoardsSloeberTxt(File requestedFileToWorkAround) {
 						FileUtils.write(boardsSloeberTXT, boardsTXT, Charset.defaultCharset());
 					}
 				} catch (IOException e) {
-					// TODO Auto-generated catch block
-					e.printStackTrace();
+					Common.log(new Status(IStatus.WARNING, Activator.getId(),
+							"Failed to apply work arounds to " + requestedFileToWorkAround.toString(), e));
+					return requestedFileToWorkAround;
 				}
 			}
 		}

io.sloeber.tests/src/io/sloeber/core/RegressionTest.java

@@ -27,7 +27,7 @@
 import io.sloeber.providers.ESP8266;
 import io.sloeber.providers.MCUBoard;
 
-@SuppressWarnings("nls")
+@SuppressWarnings({"nls","static-method"})
 public class RegressionTest {
 	private static final boolean reinstall_boards_and_libraries = false;
 
@@ -64,7 +64,6 @@ public static void installAdditionalBoards() {
 	 * make sure when switching between a board with variant file and without
 	 * the build still succeeds
 	 */
-	@SuppressWarnings("static-method")
 	@Test
 	public void issue555() {
 		if (MySystem.getTeensyPlatform().isEmpty()) {
@@ -123,7 +122,6 @@ public void issue555() {
 	 * support void loop{};
 	 * @throws Exception
 	 */
-	@SuppressWarnings("static-method")
 	@Test
 	public void issue687() throws Exception {
 	    Arduino.installLatestAVRBoards();
@@ -157,7 +155,6 @@ public void issue687() throws Exception {
 	 * support void loop{};
 	 * @throws Exception
 	 */
-	@SuppressWarnings("static-method")
 	@Test
 	public void issue1047_Board_Names_Can_Be_used_as_Strings() throws Exception {
 		MCUBoard unoBoard = ESP8266.nodeMCU();
@@ -191,7 +188,6 @@ public void issue1047_Board_Names_Can_Be_used_as_Strings() throws Exception {
 	 * code checks whether these defines are set properly
 	 * @throws Exception
 	 */
-	@SuppressWarnings("static-method")
 	@Test
 	public void are_jantjes_options_taken_into_account() throws Exception {
 	    Arduino.installLatestAVRBoards();
@@ -234,7 +230,6 @@ public void are_jantjes_options_taken_into_account() throws Exception {
 	 * properly by the ino to cpp parser
 	 * @throws Exception
 	 */
-	@SuppressWarnings("static-method")
 	@Test
 	public void are_defines_before_includes_taken_into_account() throws Exception {
 	    Arduino.installLatestAVRBoards();
@@ -271,7 +266,6 @@ public void are_defines_before_includes_taken_into_account() throws Exception {
 	 * be handled properly by the ino to cpp parser
 	 * @throws Exception
 	 */
-	@SuppressWarnings("static-method")
 	@Test
 	public void is_extern_C_taken_into_account() throws Exception {
 	    Arduino.installLatestAVRBoards();