Merge pull request #417 from DevFactory/release/multiple-code-improvements-fix-5

multiple code improvements: squid:S1118, squid:S1197, squid:UselessParenthesesCheck, squid:CommentedOutCodeLine, squid:S2864

Author: jantje

it.baeyens.arduino.core/src/it/baeyens/arduino/managers/ArduinoPlatform.java

@@ -145,12 +145,12 @@ public Properties getPlatformProperties() throws CoreException {
 	    this.platformProperties = new Properties();
 	    try (BufferedReader reader = new BufferedReader(new FileReader(getPlatformFile()))) {
 		// There are regex's here and need to preserve the \'s
-		StringBuffer buffer = new StringBuffer();
+		StringBuilder builder = new StringBuilder();
 		for (String line = reader.readLine(); line != null; line = reader.readLine()) {
-		    buffer.append(line.replace("\\", "\\\\")); //$NON-NLS-1$ //$NON-NLS-2$
-		    buffer.append('\n');
+		    builder.append(line.replace("\\", "\\\\")); //$NON-NLS-1$ //$NON-NLS-2$
+		    builder.append('\n');
 		}
-		try (Reader reader1 = new StringReader(buffer.toString())) {
+		try (Reader reader1 = new StringReader(builder.toString())) {
 		    this.platformProperties.load(reader1);
 		}
 	    } catch (IOException e) {

it.baeyens.arduino.core/src/it/baeyens/arduino/managers/Manager.java

@@ -64,6 +64,8 @@ public class Manager {
 	static private List<PackageIndex> packageIndices;
 	static private LibraryIndex libraryIndex;
 
+	private Manager() {}
+
 	private static void internalLoadIndices() {
 		String[] boardUrls = ConfigurationPreferences.getBoardURLList();
 		packageIndices = new ArrayList<>(boardUrls.length);
@@ -100,7 +102,7 @@ public static void startup_Pluging(IProgressMonitor monitor) {
 				if (pkg != null) {
 					ArduinoPlatform platform = pkg.getLatestPlatform(platformName);
 					if (platform == null) {
-						ArduinoPlatform platformList[] = new ArduinoPlatform[pkg.getLatestPlatforms().size()];
+						ArduinoPlatform[] platformList = new ArduinoPlatform[pkg.getLatestPlatforms().size()];
 						pkg.getLatestPlatforms().toArray(platformList);
 						platform = platformList[0];
 					}
@@ -169,7 +171,6 @@ static public IStatus downloadAndInstall(ArduinoPlatform platform, boolean force
 			}
 		}
 
-		// mstatus.add(make_eclipse_plugin_txt_file(platform));
 		return mstatus.getChildren().length == 0 ? Status.OK_STATUS : mstatus;
 
 	}
@@ -327,8 +328,8 @@ public static List<ArduinoPlatform> getPlatforms() {
 		return platforms;
 	}
 
-	public static ArduinoPlatform getPlatform(String PlatformTxt) {
-		String searchString = new File(PlatformTxt).toString();
+	public static ArduinoPlatform getPlatform(String platformTxt) {
+		String searchString = new File(platformTxt).toString();
 		for (PackageIndex index : packageIndices) {
 			for (Package pkg : index.getPackages()) {
 				for (ArduinoPlatform curPlatform : pkg.getPlatforms()) {
@@ -627,8 +628,8 @@ public static IStatus extract(ArchiveInputStream in, File destFolder, int stripP
 		}
 
 		// Set folders timestamps
-		for (File folder : foldersTimestamps.keySet()) {
-			folder.setLastModified(foldersTimestamps.get(folder).longValue());
+		for (Map.Entry<File, Long> entry : foldersTimestamps.entrySet()) {
+			entry.getKey().setLastModified(entry.getValue().longValue());
 		}
 
 		return Status.OK_STATUS;
@@ -672,7 +673,7 @@ private static void copyStreamToFile(InputStream in, long size, File outputFile)
 
 			// if size is not available, copy until EOF...
 			if (size == -1) {
-				byte buffer[] = new byte[4096];
+				byte[] buffer = new byte[4096];
 				int length;
 				while ((length = in.read(buffer)) != -1) {
 					fos.write(buffer, 0, length);
@@ -681,7 +682,7 @@ private static void copyStreamToFile(InputStream in, long size, File outputFile)
 			}
 
 			// ...else copy just the needed amount of bytes
-			byte buffer[] = new byte[4096];
+			byte[] buffer = new byte[4096];
 			long leftToWrite = size;
 			while (leftToWrite > 0) {
 				int length = in.read(buffer);