From 805a03e39a39b869b93ff01c716dd1799f8c73da Mon Sep 17 00:00:00 2001 From: jan Date: Mon, 17 Nov 2025 18:57:15 +0100 Subject: [PATCH 1/6] Revert "pde plugin is needed for the builders setings" This reverts commit 8e3f00314b5b2c2f539b713a08dad37407b709e6. --- io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF b/io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF index 6d7f7827..60e7d1c6 100644 --- a/io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF +++ b/io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF @@ -16,9 +16,7 @@ Require-Bundle: org.eclipse.tools.templates.ui, org.eclipse.cdt.ui, org.eclipse.core.filesystem, io.sloeber.autoBuild;bundle-version="4.4.1", - org.eclipse.tools.templates.core;bundle-version="2.0.0", - org.eclipse.pde;bundle-version="3.13.3200", - org.eclipse.pde.ui;bundle-version="3.16.200" + org.eclipse.tools.templates.core;bundle-version="2.0.0" Bundle-RequiredExecutionEnvironment: JavaSE-21 Bundle-Vendor: Sloeber.io Bundle-ActivationPolicy: lazy From c32e65918cb4a30471a9c6350ee2e16bca0638ae Mon Sep 17 00:00:00 2001 From: jan Date: Mon, 17 Nov 2025 19:39:01 +0100 Subject: [PATCH 2/6] Revert "Revert "pde plugin is needed for the builders setings"" This reverts commit 805a03e39a39b869b93ff01c716dd1799f8c73da. --- io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF b/io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF index 60e7d1c6..6d7f7827 100644 --- a/io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF +++ b/io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF @@ -16,7 +16,9 @@ Require-Bundle: org.eclipse.tools.templates.ui, org.eclipse.cdt.ui, org.eclipse.core.filesystem, io.sloeber.autoBuild;bundle-version="4.4.1", - org.eclipse.tools.templates.core;bundle-version="2.0.0" + org.eclipse.tools.templates.core;bundle-version="2.0.0", + org.eclipse.pde;bundle-version="3.13.3200", + org.eclipse.pde.ui;bundle-version="3.16.200" Bundle-RequiredExecutionEnvironment: JavaSE-21 Bundle-Vendor: Sloeber.io Bundle-ActivationPolicy: lazy From 63c13ec0a141cef504f615bebd500b1cd46a8690 Mon Sep 17 00:00:00 2001 From: jan Date: Mon, 17 Nov 2025 19:43:06 +0100 Subject: [PATCH 3/6] Revert "Revert "Revert "pde plugin is needed for the builders setings""" This reverts commit c32e65918cb4a30471a9c6350ee2e16bca0638ae. --- io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF b/io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF index 6d7f7827..60e7d1c6 100644 --- a/io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF +++ b/io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF @@ -16,9 +16,7 @@ Require-Bundle: org.eclipse.tools.templates.ui, org.eclipse.cdt.ui, org.eclipse.core.filesystem, io.sloeber.autoBuild;bundle-version="4.4.1", - org.eclipse.tools.templates.core;bundle-version="2.0.0", - org.eclipse.pde;bundle-version="3.13.3200", - org.eclipse.pde.ui;bundle-version="3.16.200" + org.eclipse.tools.templates.core;bundle-version="2.0.0" Bundle-RequiredExecutionEnvironment: JavaSE-21 Bundle-Vendor: Sloeber.io Bundle-ActivationPolicy: lazy From cf628258fb5f094a676c480025e39f5533ef76c0 Mon Sep 17 00:00:00 2001 From: jan Date: Mon, 17 Nov 2025 23:57:00 +0100 Subject: [PATCH 4/6] only depend on pde (exclude pde.ui) --- io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF b/io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF index 60e7d1c6..e84e6e02 100644 --- a/io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF +++ b/io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF @@ -16,7 +16,8 @@ Require-Bundle: org.eclipse.tools.templates.ui, org.eclipse.cdt.ui, org.eclipse.core.filesystem, io.sloeber.autoBuild;bundle-version="4.4.1", - org.eclipse.tools.templates.core;bundle-version="2.0.0" + org.eclipse.tools.templates.core;bundle-version="2.0.0", + org.eclipse.pde;bundle-version="3.13.3200" Bundle-RequiredExecutionEnvironment: JavaSE-21 Bundle-Vendor: Sloeber.io Bundle-ActivationPolicy: lazy From b6e2ce1c40d84c9d94bd1bdaf2e338ed20b99419 Mon Sep 17 00:00:00 2001 From: jan Date: Tue, 18 Nov 2025 00:44:09 +0100 Subject: [PATCH 5/6] Now add the pde.ui plugin (I expect this to break the build) --- io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF b/io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF index e84e6e02..6d7f7827 100644 --- a/io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF +++ b/io.sloeber.autoBuild.ui/META-INF/MANIFEST.MF @@ -17,7 +17,8 @@ Require-Bundle: org.eclipse.tools.templates.ui, org.eclipse.core.filesystem, io.sloeber.autoBuild;bundle-version="4.4.1", org.eclipse.tools.templates.core;bundle-version="2.0.0", - org.eclipse.pde;bundle-version="3.13.3200" + org.eclipse.pde;bundle-version="3.13.3200", + org.eclipse.pde.ui;bundle-version="3.16.200" Bundle-RequiredExecutionEnvironment: JavaSE-21 Bundle-Vendor: Sloeber.io Bundle-ActivationPolicy: lazy From 6500a5a29bf456ed87e268fc7db6fc9566513490 Mon Sep 17 00:00:00 2001 From: jan Date: Tue, 18 Nov 2025 02:48:18 +0100 Subject: [PATCH 6/6] add if(){return;} before assumeFalse (for testing) --- .../autoBuild/regression/AutoBuildCreateBasicProjects.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/io.sloeber.autoBuild.test/src/io/sloeber/autoBuild/regression/AutoBuildCreateBasicProjects.java b/io.sloeber.autoBuild.test/src/io/sloeber/autoBuild/regression/AutoBuildCreateBasicProjects.java index 2d3c3a8b..0b49bb6e 100644 --- a/io.sloeber.autoBuild.test/src/io/sloeber/autoBuild/regression/AutoBuildCreateBasicProjects.java +++ b/io.sloeber.autoBuild.test/src/io/sloeber/autoBuild/regression/AutoBuildCreateBasicProjects.java @@ -192,6 +192,9 @@ void testInternaltBuilderRoot(String inProjectName, String extensionPointID, Str void testMakeBuilderRoot(String inProjectName, String extensionPointID, String extensionID, String projectTypeID, String natureID, ICodeProvider codeProvider, IBuildTools buildTools) throws Exception { if (doTestMakeBuilder) { + if(buildTools.getProviderID().equals("io.sloeber.autoBuild.Path.BuildToolProvider")) { + return; + } Assumptions.assumeFalse(buildTools.getProviderID().equals("io.sloeber.autoBuild.Path.BuildToolProvider"),"Ignoring as make is not assumed on the path") ; String projectName = "make_" + inProjectName; if (projectName.length() > 40) {