autocomplete widget validation and related object creation, added obj param to extra context methods, allow override back url in change view (#92)

* feat: autocomplete widget - validate restricted queryset and allow create new objects

* fix: missing data during view instancing

* triv: validate multiselect in widget

* triv: pass obj to all methods of change view extra context

* triv: added obj param to reflect admin changes

* triv: fixed get_parent_instance_from_request for new objects

* triv: style fix

* triv: add option for autocomplete widget to reload parent change view when saving related model instance in modal

* triv: removed unused import

* triv: allow override back url in change form view

* triv: raise ImproperlyConfigured for multiselect with allow_add

* fix lxml version

* triv: fixed case where newly created value didn't propagate to context data due to form being bound which is caused by other field error

* triv: check for referer

* triv: poetry lock

* triv: update workflow

* bump version

* triv: revert form field changes

* triv: save newly created value in autocomplete widget to request data and retrieve it in context data if there is other validation error in form

* Revert "triv: pass obj to all methods of change view extra context"

This reverts commit 41b61d8

* Revert "triv: added obj param to reflect admin changes"

This reverts commit 34d23bf.

* triv: black format

Author: MartinCervenkaSB

.github/workflows/workflow.yml

@@ -24,7 +24,11 @@ jobs:
     - name: Set up Python
       uses: actions/setup-python@v4
       with:
-        python-version: "3.x"
+        python-version: "3.13"
+    - name: Install system dependencies for lxml
+      run: |
+        sudo apt-get update
+        sudo apt-get install -y libxml2-dev libxslt1-dev zlib1g-dev
     - name: Install dependencies
       run: |
         python3 -m pip install poetry==1.8.5

poetry.lock

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "django-smartbase-admin"
-version = "1.0.33"
+version = "1.0.34"
 description = ""
 authors = ["SmartBase <info@smartbase.sk>"]
 readme = "README.md"

pyproject.toml

@@ -4,6 +4,7 @@
 from collections.abc import Iterable
 from functools import partial
 from typing import Any
+from urllib.parse import urlparse
 
 from ckeditor.fields import RichTextFormField
 from ckeditor_uploader.fields import RichTextUploadingFormField
@@ -30,7 +31,7 @@
 from django.http import HttpResponse
 from django.template.loader import render_to_string
 from django.template.response import TemplateResponse
-from django.urls import reverse, NoReverseMatch
+from django.urls import reverse, NoReverseMatch, resolve
 from django.utils.safestring import mark_safe, SafeString
 from django.utils.text import capfirst
 from django.utils.translation import gettext_lazy as _
@@ -126,6 +127,7 @@
     SBADMIN_PARENT_INSTANCE_PK_VAR,
     SBADMIN_PARENT_INSTANCE_LABEL_VAR,
     SBADMIN_PARENT_INSTANCE_FIELD_NAME_VAR,
+    SBADMIN_RELOAD_ON_SAVE_VAR,
 )
 from django_smartbase_admin.engine.const import (
     OBJECT_ID_PLACEHOLDER,
@@ -316,6 +318,13 @@ def __init__(self, *args, **kwargs):
             "request", SBAdminThreadLocalService.get_request()
         )
         super().__init__(*args, **kwargs)
+        self.init_widgets_dynamic(threadsafe_request)
+        for field in self.declared_fields:
+            form_field = self.fields.get(field)
+            if form_field:
+                self.assign_widget_to_form_field(form_field, request=threadsafe_request)
+
+    def init_widgets_dynamic(self, request):
         for field in self.fields:
             if not hasattr(self.fields[field].widget, "init_widget_dynamic"):
                 continue
@@ -324,12 +333,8 @@ def __init__(self, *args, **kwargs):
                 self.fields[field],
                 field,
                 self.view,
-                threadsafe_request,
+                request,
             )
-        for field in self.declared_fields:
-            form_field = self.fields.get(field)
-            if form_field:
-                self.assign_widget_to_form_field(form_field, request=threadsafe_request)
 
 
 class SBAdminBaseForm(SBAdminBaseFormInit, forms.ModelForm):
@@ -822,7 +827,14 @@ def get_additional_filter_for_previous_next_context(self, request, object_id) ->
         return Q()
 
     def get_change_view_context(self, request, object_id) -> dict | dict[str, Any]:
-        return {"show_back_button": True}
+        return {
+            "show_back_button": True,
+            "back_url": reverse(
+                "sb_admin:{}_{}_changelist".format(
+                    self.opts.app_label, self.opts.model_name
+                )
+            ),
+        }
 
     def get_previous_next_context(self, request, object_id) -> dict | dict[str, Any]:
         if not self.sbadmin_previous_next_buttons_enabled or not object_id:
@@ -958,7 +970,7 @@ def get_modal_save_response(cls, request, obj):
                 "field": request.POST.get("sb_admin_source_field"),
                 "id": obj.pk,
                 "label": str(obj),
-                "reload": request.POST.get("sbadmin_reload_on_save") == "1",
+                "reload": request.POST.get(SBADMIN_RELOAD_ON_SAVE_VAR) == "1",
             },
         )
         trigger_client_event(response, "hideModal", {"elt": "sb-admin-modal"})
@@ -1051,6 +1063,31 @@ def register_autocomplete_views(self, request) -> None:
         self.initialize_form_class(form_class, request)
         form_class()
 
+    def get_parent_instance_from_request(self):
+        # Try to get parent instance from request referrer
+        request = (
+            getattr(self, "threadsafe_request", None)
+            or SBAdminThreadLocalService.get_request()
+        )
+        allowed = SBAdminViewService.has_permission(
+            request=request, model=self.parent_model, permission="view"
+        )
+        if not allowed:
+            return None
+
+        referer = request.META.get("HTTP_REFERER")
+        if not referer:
+            return None
+        resolved = resolve(urlparse(referer).path)
+        # Try common kwargs for object ID
+        object_id = resolved.kwargs.get("object_id")
+        if not object_id:
+            return None
+        base_qs = SBAdminViewService.get_restricted_queryset(
+            self.parent_model, request, request.request_data
+        )
+        return base_qs.get(pk=object_id)
+
     def get_context_data(self, request) -> dict[str, Any]:
         is_sortable_active: bool = self.sortable_field_name and (
             self.has_add_permission(request) or self.has_change_permission(request)