refactor(scripts): standardize logger method usage in validation scripts

Replace inconsistent .error() usage with proper .fail() and .log() methods
across validation scripts for consistent user-facing output.

Pattern standardized:
- .fail() for validation failure headers
- .log() for detail/informational lines
- .error() reserved for actual exceptions only

Affects validation scripts:
- esbuild-minify.mjs
- bundle-deps.mjs
- no-link-deps.mjs

Author: jdalton

scripts/validation/bundle-deps.mjs

@@ -371,12 +371,12 @@ async function main() {
     }
 
     if (violations.length > 0) {
-      logger.error('❌ Bundle dependencies validation failed\n')
+      logger.fail('Bundle dependencies validation failed\n')
 
       for (const violation of violations) {
-        logger.error(`  ${violation.message}`)
-        logger.error(`  ${violation.fix}`)
-        logger.error('')
+        logger.log(`  ${violation.message}`)
+        logger.log(`  ${violation.fix}`)
+        logger.log('')
       }
     }
 
@@ -392,7 +392,7 @@ async function main() {
     // Only fail on violations, not warnings
     process.exitCode = violations.length > 0 ? 1 : 0
   } catch (error) {
-    logger.error('Validation failed:', error.message)
+    logger.fail('Validation failed:', error.message)
     process.exitCode = 1
   }
 }

scripts/validation/esbuild-minify.mjs

@@ -52,7 +52,7 @@ async function validateEsbuildMinify() {
 
     return violations
   } catch (error) {
-    logger.error(`Failed to load esbuild config: ${error.message}`)
+    logger.fail(`Failed to load esbuild config: ${error.message}`)
     process.exitCode = 1
     return []
   }
@@ -67,25 +67,23 @@ async function main() {
     return
   }
 
-  logger.error('❌ esbuild minify validation failed\n')
+  logger.fail('esbuild minify validation failed\n')
 
   for (const violation of violations) {
-    logger.error(`  ${violation.message}`)
-    logger.error(`  Found: minify: ${violation.value}`)
-    logger.error('  Expected: minify: false')
-    logger.error(`  Location: ${violation.location}`)
-    logger.error('')
+    logger.log(`  ${violation.message}`)
+    logger.log(`  Found: minify: ${violation.value}`)
+    logger.log('  Expected: minify: false')
+    logger.log(`  Location: ${violation.location}`)
+    logger.log('')
   }
 
-  logger.error(
-    'Minification breaks ESM/CJS interop and makes debugging harder.',
-  )
-  logger.error('')
+  logger.log('Minification breaks ESM/CJS interop and makes debugging harder.')
+  logger.log('')
 
   process.exitCode = 1
 }
 
 main().catch(error => {
-  logger.error('Validation failed:', error)
+  logger.fail('Validation failed:', error)
   process.exitCode = 1
 })

scripts/validation/no-link-deps.mjs

@@ -123,26 +123,26 @@ async function main() {
   }
 
   if (allViolations.length > 0) {
-    logger.error('❌ Found link: dependencies (prohibited)')
-    logger.error('')
-    logger.error(
+    logger.fail('Found link: dependencies (prohibited)')
+    logger.log('')
+    logger.log(
       'Use workspace: protocol for monorepo packages or catalog: for centralized versions.',
     )
-    logger.error('')
+    logger.log('')
 
     for (const violation of allViolations) {
       const relativePath = path.relative(rootPath, violation.file)
-      logger.error(`  ${relativePath}`)
-      logger.error(
+      logger.log(`  ${relativePath}`)
+      logger.log(
         `    ${violation.field}.${violation.package}: "${violation.value}"`,
       )
     }
 
-    logger.error('')
-    logger.error('Replace link: with:')
-    logger.error('  - workspace: for monorepo packages')
-    logger.error('  - catalog: for centralized version management')
-    logger.error('')
+    logger.log('')
+    logger.log('Replace link: with:')
+    logger.log('  - workspace: for monorepo packages')
+    logger.log('  - catalog: for centralized version management')
+    logger.log('')
 
     process.exitCode = 1
   } else {
@@ -151,6 +151,6 @@ async function main() {
 }
 
 main().catch(error => {
-  logger.error('Validation failed:', error)
+  logger.fail('Validation failed:', error)
   process.exitCode = 1
 })