Skip to content

Commit 0802a5d

Browse files
committed
Replaced accessor functions with the objects themselves
1 parent 16b5289 commit 0802a5d

File tree

6 files changed

+25
-95
lines changed

6 files changed

+25
-95
lines changed

src/core/modules/cvar/cvar_wrap_python.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,6 @@ DECLARE_SP_MODULE(cvar_c)
5959
//-----------------------------------------------------------------------------
6060
void export_cvar_interface()
6161
{
62-
def("get_cvar_interface", make_getter(&g_pCVar, reference_existing_object_policy()));
63-
6462
// TODO: Rename it?
6563
class_<ICvar, boost::noncopyable>("CCvar", no_init)
6664
.def("register_con_command",
@@ -89,6 +87,8 @@ void export_cvar_interface()
8987
reference_existing_object_policy()
9088
)
9189
;
90+
91+
scope().attr("cvar") = object(ptr(g_pCVar));
9292
}
9393

9494
//-----------------------------------------------------------------------------

src/core/modules/effects/effects_wrap_python.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,5 +182,5 @@ void export_effects()
182182
)
183183
;
184184

185-
def("get_effects_interface", make_getter(&effects, reference_existing_object_policy()));
185+
scope().attr("effects") = object(ptr(effects));
186186
}

src/core/modules/engine/eiface_wrap_python.cpp

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -90,15 +90,6 @@ BOOST_PYTHON_MEMBER_FUNCTION_OVERLOADS(precache_generic_overload, PrecacheGeneri
9090

9191
void export_engine_interface()
9292
{
93-
// engine server interface accesor
94-
def("get_engine_interface", make_getter(&engine, reference_existing_object_policy()));
95-
96-
// TODO
97-
// Maybe we should create a new module called "interfaces" and then expose the objects
98-
// as the following:
99-
// scope().attr("engine") = ref(engine);
100-
101-
10293
// Call engine specific implementation function
10394
IVEngineServer_Visitor(
10495

@@ -761,4 +752,6 @@ void export_engine_interface()
761752
.NOT_IMPLEMENTED("get_engine_hltv_info")
762753

763754
); // IVEngineServer_Visitor
755+
756+
scope().attr("engine") = object(ptr(engine));
764757
}

src/core/modules/events/events_wrap_python.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,5 +269,5 @@ void export_igameeventmanager()
269269
)
270270
;
271271

272-
def("get_game_event_manager", make_getter(&gameeventmanager, reference_existing_object_policy()));
272+
scope().attr("game_event_manager") = object(ptr(gameeventmanager));
273273
}

src/core/modules/globals/globals_wrap_python.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,5 +189,5 @@ void export_globals()
189189
.NOT_IMPLEMENTED_ATTR("edicts")
190190
);
191191

192-
def("get_globals", make_getter(&gpGlobals, reference_existing_object_policy()));
192+
scope().attr("globals") = object(ptr(gpGlobals));
193193
}

src/core/modules/listeners/listeners_wrap_python.cpp

Lines changed: 18 additions & 81 deletions
Original file line numberDiff line numberDiff line change
@@ -80,87 +80,24 @@ void export_listener_managers()
8080
//-------------------------------------------------------------------------
8181
// Expose the accessor functions
8282
//-------------------------------------------------------------------------
83-
def("get_client_active_listener_manager",
84-
&GetClientActiveListenerManager,
85-
"Returns the clientactive listener instance",
86-
reference_existing_object_policy()
87-
);
83+
scope().attr("client_active_listener_manager") = object(ptr(GetClientActiveListenerManager()));
84+
scope().attr("client_connect_listener_manager") = object(ptr(GetClientConnectListenerManager()));
85+
scope().attr("client_disconnect_listener_manager") = object(ptr(GetClientDisconnectListenerManager()));
86+
scope().attr("client_fully_connect_listener_manager") = object(ptr(GetClientFullyConnectListenerManager()));
87+
scope().attr("client_put_in_server_listener_manager") = object(ptr(GetClientPutInServerListenerManager()));
88+
scope().attr("client_settings_changed_listener_manager") = object(ptr(GetClientSettingsChangedListenerManager()));
8889

89-
def("get_client_connect_listener_manager",
90-
&GetClientConnectListenerManager,
91-
"Returns the clientconnect listener instance",
92-
reference_existing_object_policy()
93-
);
94-
95-
def("get_client_disconnect_listener_manager",
96-
&GetClientDisconnectListenerManager,
97-
"Returns the clientdisconnect listener instance",
98-
reference_existing_object_policy()
99-
);
100-
101-
def("get_client_fully_connect_listener_manager",
102-
&GetClientFullyConnectListenerManager,
103-
"Returns the clientfullyconnect listener instance",
104-
reference_existing_object_policy()
105-
);
106-
107-
def("get_client_put_in_server_listener_manager",
108-
&GetClientPutInServerListenerManager,
109-
"Returns the clientputinserver listener instance",
110-
reference_existing_object_policy()
111-
);
112-
113-
def("get_client_settings_changed_listener_manager",
114-
&GetClientSettingsChangedListenerManager,
115-
"Returns the clientsettingschanged listener instance",
116-
reference_existing_object_policy()
117-
);
118-
119-
def("get_level_init_listener_manager",
120-
&GetLevelInitListenerManager,
121-
"Returns the levelinit listener instance",
122-
reference_existing_object_policy()
123-
);
124-
125-
def("get_level_shutdown_listener_manager",
126-
&GetLevelShutdownListenerManager,
127-
"Returns the levelshutdown listener instance",
128-
reference_existing_object_policy()
129-
);
130-
131-
def("get_networkid_validated_listener_manager",
132-
&GetNetworkidValidatedListenerManager,
133-
"Returns the networkidvalidated listener instance",
134-
reference_existing_object_policy()
135-
);
136-
137-
def("get_on_edict_allocated_listener_manager",
138-
&GetOnEdictAllocatedListenerManager,
139-
"Returns the onedictallocated listener instance",
140-
reference_existing_object_policy()
141-
);
142-
143-
def("get_on_edict_freed_listener_manager",
144-
&GetOnEdictFreedListenerManager,
145-
"Returns the onedictfreed listener instance",
146-
reference_existing_object_policy()
147-
);
148-
149-
def("get_on_query_cvar_value_finished_listener_manager",
150-
&GetOnQueryCvarValueFinishedListenerManager,
151-
"Returns the onquerycvarvaluefinished listener instance",
152-
reference_existing_object_policy()
153-
);
154-
155-
def("get_server_activate_listener_manager",
156-
&GetServerActivateListenerManager,
157-
"Returns the serveractivate listener instance",
158-
reference_existing_object_policy()
159-
);
90+
scope().attr("level_init_listener_manager") = object(ptr(GetLevelInitListenerManager()));
91+
scope().attr("level_shutdown_listener_manager") = object(ptr(GetLevelShutdownListenerManager()));
92+
93+
scope().attr("networkid_validated_listener_manager") = object(ptr(GetNetworkidValidatedListenerManager()));
94+
95+
scope().attr("on_edict_allocated_listener_manager") = object(ptr(GetOnEdictAllocatedListenerManager()));
96+
scope().attr("on_edict_freed_listener_manager") = object(ptr(GetOnEdictFreedListenerManager()));
97+
98+
scope().attr("on_query_cvar_value_finished_listener_manager") = object(ptr(GetOnQueryCvarValueFinishedListenerManager()));
99+
100+
scope().attr("server_activate_listener_manager") = object(ptr(GetServerActivateListenerManager()));
160101

161-
def("get_tick_listener_manager",
162-
&GetTickListenerManager,
163-
"Returns the tick listener instance",
164-
reference_existing_object_policy()
165-
);
102+
scope().attr("tick_listener_manager") = object(ptr(GetTickListenerManager()));
166103
}

0 commit comments

Comments
 (0)