Skip to content

Commit c8b4423

Browse files
committed
[update] symbol为表达式时,设置paint、layout生效
review by zhaoq
1 parent 80c179f commit c8b4423

File tree

6 files changed

+8
-16
lines changed

6 files changed

+8
-16
lines changed

src/mapboxgl/overlay/symbol/SingleSymbolRender.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,11 @@ class SingleSymbolRender {
1313

1414
/**
1515
* 符号转换成图层
16-
* @param {*} layer
17-
* @param {*} before
16+
* @param {object} layer
17+
* @param {object} symbol
18+
* @param {string | undefined} before
1819
*/
1920
addLayer(layer, symbol, before) {
20-
if(layer.layout && layer.layout.visibility === 'none') {
21-
Object.assign(layer.layout, {visibility: 'visible'});
22-
}
2321
layer.paint && Object.assign(symbol.paint || {}, layer.paint);
2422
layer.layout && Object.assign(symbol.layout || {}, layer.layout);
2523
this.map.addLayerBySymbolBak({ ...layer, ...symbol }, before);

src/mapboxgl/overlay/symbol/SymbolHandler.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,9 +152,6 @@ class SymbolHandler {
152152
* @param {string} before
153153
*/
154154
addExpressionLayer(layer, before) {
155-
// symbol支持表达式的话,paint、layout不生效
156-
delete layer.paint;
157-
delete layer.layout;
158155
const rules = {
159156
match: this.getMatchLayers,
160157
case: this.getCaseLayers

src/mapboxgl/overlay/symbol/SymbolManager.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ class SymbolManager {
99
}
1010

1111
addSymbol(id, symbol) {
12+
symbol.layout && delete symbol.layout.visibility;
1213
this.symbols[id] = symbol;
1314
}
1415

src/maplibregl/overlay/symbol/SingleSymbolRender.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,11 @@ class SingleSymbolRender {
1313

1414
/**
1515
* 符号转换成图层
16-
* @param {*} layer
17-
* @param {*} before
16+
* @param {object} layer
17+
* @param {object} symbol
18+
* @param {string | undefined} before
1819
*/
1920
addLayer(layer, symbol, before) {
20-
if(layer.layout && layer.layout.visibility === 'none') {
21-
Object.assign(layer.layout, {visibility: 'visible'});
22-
}
2321
layer.paint && Object.assign(symbol.paint || {}, layer.paint);
2422
layer.layout && Object.assign(symbol.layout || {}, layer.layout);
2523
this.map.addLayerBySymbolBak({ ...layer, ...symbol }, before);

src/maplibregl/overlay/symbol/SymbolHandler.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,9 +152,6 @@ class SymbolHandler {
152152
* @param {string} before
153153
*/
154154
addExpressionLayer(layer, before) {
155-
// symbol支持表达式的话,paint、layout不生效
156-
delete layer.paint;
157-
delete layer.layout;
158155
const rules = {
159156
match: this.getMatchLayers,
160157
case: this.getCaseLayers

src/maplibregl/overlay/symbol/SymbolManager.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ class SymbolManager {
99
}
1010

1111
addSymbol(id, symbol) {
12+
symbol.layout && delete symbol.layout.visibility;
1213
this.symbols[id] = symbol;
1314
}
1415

0 commit comments

Comments
 (0)