Add back deprecated constructors with tests

Author: MilesCranmer

src/deprecated.jl

@@ -1,4 +1,42 @@
 import Base: @deprecate
+import .EquationModule: Node
 
 @deprecate set_constants set_constants!
 @deprecate simplify_tree simplify_tree!
+
+function Node(d::Integer, c::Bool, v::T) where {T}
+    Base.depwarn("Node(d, c, v) is deprecated. Use Node{T}(val=v) instead.", :Node)
+    @assert d == 1
+    @assert c == true
+    return Node{T}(; val=v)
+end
+function Node(::Type{T}, d::Integer, c::Bool, v::_T) where {T,_T}
+    Base.depwarn("Node(T, d, c, v) is deprecated. Use Node{T}(val=v) instead.", :Node)
+    @assert d == 1
+    @assert c == true
+    return Node{T}(; val=v)
+end
+function Node(::Type{T}, d::Integer, c::Bool, ::Nothing, f::Integer) where {T}
+    Base.depwarn(
+        "Node(T, d, c, v, f) is deprecated. Use Node{T}(feature=f) instead.", :Node
+    )
+    @assert d == 1
+    @assert c == false
+    return Node{T}(; feature=f)
+end
+function Node(d::Integer, ::Bool, ::Nothing, ::Integer, o::Integer, l::Node)
+    Base.depwarn(
+        "Node(d, c, v, f, o, l) is deprecated. Use Node(operator=o, left=l) instead.", :Node
+    )
+    @assert d == 1
+    return Node(; op=o, l=l)
+end
+function Node(
+    d::Integer, ::Bool, ::Nothing, ::Integer, o::Integer, l::Node{T}, r::Node{T}
+) where {T}
+    Base.depwarn(
+        "Node(d, c, v, f, o, l, r) is deprecated. Use Node(op=o, l=l, r=r) instead.", :Node
+    )
+    @assert d == 2
+    return Node(; op=o, l=l, r=r)
+end

test/test_deprecations.jl

@@ -20,3 +20,26 @@ for constructor in (OperatorEnum, GenericOperatorEnum)
             [1.0; 2.0;;]
         )
 end
+
+if VERSION >= v"1.9"
+    @test_logs (:warn, r"Node\(d, c, v\) is deprecated.*") (
+        n = Node(1, true, 1.0 + 0im); @assert (n.val isa ComplexF64)
+    )
+    @test_logs (:warn, r"Node\(T, d, c, v\) is deprecated.*") (
+        n = Node(Float32, 1, true, 1.0 + 0im); @assert (n.val isa Float32)
+    )
+    @test_logs (:warn, r"Node\(T, d, c, v, f\) is deprecated.*") (
+        n = Node(Float32, 1, false, nothing, 1); @assert (n.feature == 1)
+    )
+    @test_logs (:warn, r"Node\(d, c, v, f, o, l\) is deprecated.*") (
+        x1 = Node(; feature=1);
+        n = Node(1, true, nothing, 1, 3, x1);
+        @assert (n.op == 3 && n.l === x1)
+    )
+    @test_logs (:warn, r"Node\(d, c, v, f, o, l, r\) is deprecated.*") (
+        x1 = Node(; feature=1);
+        x2 = Node(; feature=2);
+        n = Node(2, true, nothing, 1, 1, x1, x2);
+        @assert (n.op == 1 && n.l === x1 && n.r === x2)
+    )
+end