Skip to content

Commit 60996c8

Browse files
committed
Fix extension interface
1 parent fe0bb48 commit 60996c8

File tree

3 files changed

+13
-8
lines changed

3 files changed

+13
-8
lines changed

ext/DynamicExpressionsSymbolicUtilsExt.jl

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,15 @@ export node_to_symbolic, symbolic_to_node
55
import Base: convert
66
using SymbolicUtils
77
if isdefined(Base, :get_extension)
8+
import DynamicExpressions.EquationModule: Node, DEFAULT_NODE_TYPE
9+
import DynamicExpressions.OperatorEnumModule: AbstractOperatorEnum
10+
import DynamicExpressions.UtilsModule: isgood, isbad, @return_on_false
11+
import DynamicExpressions.ExtensionInterfaceModule: node_to_symbolic, symbolic_to_node
12+
else
813
import ..DynamicExpressions.EquationModule: Node, DEFAULT_NODE_TYPE
914
import ..DynamicExpressions.OperatorEnumModule: AbstractOperatorEnum
1015
import ..DynamicExpressions.UtilsModule: isgood, isbad, @return_on_false
11-
else
12-
import ..EquationModule: Node, DEFAULT_NODE_TYPE
13-
import ..OperatorEnumModule: AbstractOperatorEnum
14-
import ..UtilsModule: isgood, isbad, @return_on_false
16+
import ..DynamicExpressions.ExtensionInterfaceModule: node_to_symbolic, symbolic_to_node
1517
end
1618

1719
const SYMBOLIC_UTILS_TYPES = Union{<:Number,SymbolicUtils.Symbolic{<:Number}}
@@ -190,8 +192,10 @@ function node_to_symbolic(
190192
end
191193

192194
function symbolic_to_node(
193-
eqn::T, operators::AbstractOperatorEnum; varMap::Union{Array{String,1},Nothing}=nothing
194-
)::Node where {T<:SymbolicUtils.Symbolic}
195+
eqn::SymbolicUtils.Symbolic,
196+
operators::AbstractOperatorEnum;
197+
varMap::Union{Array{String,1},Nothing}=nothing,
198+
)::Node
195199
return convert(Node, eqn, operators; varMap=varMap)
196200
end
197201

src/DynamicExpressions.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ include("EvaluateEquationDerivative.jl")
99
include("EvaluationHelpers.jl")
1010
include("SimplifyEquation.jl")
1111
include("OperatorEnumConstruction.jl")
12+
include("ExtensionInterface.jl")
1213

1314
if !isdefined(Base, :get_extension)
1415
using Requires
@@ -34,13 +35,12 @@ using Reexport
3435
eval_diff_tree_array, eval_grad_tree_array
3536
@reexport import .SimplifyEquationModule: combine_operators, simplify_tree
3637
@reexport import .EvaluationHelpersModule
38+
@reexport import .ExtensionInterfaceModule: node_to_symbolic, symbolic_to_node
3739

3840
function __init__()
3941
@static if !isdefined(Base, :get_extension)
4042
@require SymbolicUtils = "d1185830-fcd6-423d-90d6-eec64667417b" begin
4143
include("../ext/DynamicExpressionsSymbolicUtilsExt.jl")
42-
@reexport import .DynamicExpressionsSymbolicUtilsExt:
43-
node_to_symbolic, symbolic_to_node
4444
end
4545
end
4646
end

test/test_symbolic_utils.jl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
using SymbolicUtils
12
using DynamicExpressions
23
using Test
34
include("test_params.jl")

0 commit comments

Comments
 (0)