refactor: renamed add handle method on file handles class

HarrisonTCodes · HarrisonTCodes · commit 15ed8d6f8239 · 2025-11-20T18:00:43.000Z
diff --git a/src/TestableIO.System.IO.Abstractions.TestingHelpers/FileHandles.cs b/src/TestableIO.System.IO.Abstractions.TestingHelpers/FileHandles.cs
@@ -7,7 +7,7 @@ public class FileHandles
 {
     private readonly ConcurrentDictionary<string, ConcurrentDictionary<Guid, (FileAccess access, FileShare share)>> handles = new();
 
-    public void TryAddHandle(string path, Guid guid, FileAccess access, FileShare share)
+    public void AddHandle(string path, Guid guid, FileAccess access, FileShare share)
     {
         var pathHandles = handles.GetOrAdd(
             path, 
diff --git a/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileStream.cs b/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileStream.cs
@@ -101,7 +101,7 @@ public MockFileStream(
             mockFileDataAccessor.AddFile(path, fileData);
         }
 
-        mockFileDataAccessor.FileHandles.TryAddHandle(path, guid, access, share);
+        mockFileDataAccessor.FileHandles.AddHandle(path, guid, access, share);
         this.access = access;
         this.share = share;
     }
diff --git a/tests/TestableIO.System.IO.Abstractions.Api.Tests/Expected/TestableIO.System.IO.Abstractions.TestingHelpers_net10.0.txt b/tests/TestableIO.System.IO.Abstractions.Api.Tests/Expected/TestableIO.System.IO.Abstractions.TestingHelpers_net10.0.txt
@@ -3,8 +3,8 @@
 public class FileHandles
 {
     public FileHandles() { }
+    public void AddHandle(string path, System.Guid guid, System.IO.FileAccess access, System.IO.FileShare share) { }
     public void RemoveHandle(string path, System.Guid guid) { }
-    public void TryAddHandle(string path, System.Guid guid, System.IO.FileAccess access, System.IO.FileShare share) { }
 }
 namespace System.IO.Abstractions.TestingHelpers
 {
diff --git a/tests/TestableIO.System.IO.Abstractions.Api.Tests/Expected/TestableIO.System.IO.Abstractions.TestingHelpers_net472.txt b/tests/TestableIO.System.IO.Abstractions.Api.Tests/Expected/TestableIO.System.IO.Abstractions.TestingHelpers_net472.txt
@@ -3,8 +3,8 @@
 public class FileHandles
 {
     public FileHandles() { }
+    public void AddHandle(string path, System.Guid guid, System.IO.FileAccess access, System.IO.FileShare share) { }
     public void RemoveHandle(string path, System.Guid guid) { }
-    public void TryAddHandle(string path, System.Guid guid, System.IO.FileAccess access, System.IO.FileShare share) { }
 }
 namespace System.IO.Abstractions.TestingHelpers
 {
diff --git a/tests/TestableIO.System.IO.Abstractions.Api.Tests/Expected/TestableIO.System.IO.Abstractions.TestingHelpers_net6.0.txt b/tests/TestableIO.System.IO.Abstractions.Api.Tests/Expected/TestableIO.System.IO.Abstractions.TestingHelpers_net6.0.txt
@@ -3,8 +3,8 @@
 public class FileHandles
 {
     public FileHandles() { }
+    public void AddHandle(string path, System.Guid guid, System.IO.FileAccess access, System.IO.FileShare share) { }
     public void RemoveHandle(string path, System.Guid guid) { }
-    public void TryAddHandle(string path, System.Guid guid, System.IO.FileAccess access, System.IO.FileShare share) { }
 }
 namespace System.IO.Abstractions.TestingHelpers
 {
diff --git a/tests/TestableIO.System.IO.Abstractions.Api.Tests/Expected/TestableIO.System.IO.Abstractions.TestingHelpers_net8.0.txt b/tests/TestableIO.System.IO.Abstractions.Api.Tests/Expected/TestableIO.System.IO.Abstractions.TestingHelpers_net8.0.txt
@@ -3,8 +3,8 @@
 public class FileHandles
 {
     public FileHandles() { }
+    public void AddHandle(string path, System.Guid guid, System.IO.FileAccess access, System.IO.FileShare share) { }
     public void RemoveHandle(string path, System.Guid guid) { }
-    public void TryAddHandle(string path, System.Guid guid, System.IO.FileAccess access, System.IO.FileShare share) { }
 }
 namespace System.IO.Abstractions.TestingHelpers
 {
diff --git a/tests/TestableIO.System.IO.Abstractions.Api.Tests/Expected/TestableIO.System.IO.Abstractions.TestingHelpers_net9.0.txt b/tests/TestableIO.System.IO.Abstractions.Api.Tests/Expected/TestableIO.System.IO.Abstractions.TestingHelpers_net9.0.txt
@@ -3,8 +3,8 @@
 public class FileHandles
 {
     public FileHandles() { }
+    public void AddHandle(string path, System.Guid guid, System.IO.FileAccess access, System.IO.FileShare share) { }
     public void RemoveHandle(string path, System.Guid guid) { }
-    public void TryAddHandle(string path, System.Guid guid, System.IO.FileAccess access, System.IO.FileShare share) { }
 }
 namespace System.IO.Abstractions.TestingHelpers
 {
diff --git a/tests/TestableIO.System.IO.Abstractions.Api.Tests/Expected/TestableIO.System.IO.Abstractions.TestingHelpers_netstandard2.0.txt b/tests/TestableIO.System.IO.Abstractions.Api.Tests/Expected/TestableIO.System.IO.Abstractions.TestingHelpers_netstandard2.0.txt
@@ -3,8 +3,8 @@
 public class FileHandles
 {
     public FileHandles() { }
+    public void AddHandle(string path, System.Guid guid, System.IO.FileAccess access, System.IO.FileShare share) { }
     public void RemoveHandle(string path, System.Guid guid) { }
-    public void TryAddHandle(string path, System.Guid guid, System.IO.FileAccess access, System.IO.FileShare share) { }
 }
 namespace System.IO.Abstractions.TestingHelpers
 {
diff --git a/tests/TestableIO.System.IO.Abstractions.Api.Tests/Expected/TestableIO.System.IO.Abstractions.TestingHelpers_netstandard2.1.txt b/tests/TestableIO.System.IO.Abstractions.Api.Tests/Expected/TestableIO.System.IO.Abstractions.TestingHelpers_netstandard2.1.txt
@@ -3,8 +3,8 @@
 public class FileHandles
 {
     public FileHandles() { }
+    public void AddHandle(string path, System.Guid guid, System.IO.FileAccess access, System.IO.FileShare share) { }
     public void RemoveHandle(string path, System.Guid guid) { }
-    public void TryAddHandle(string path, System.Guid guid, System.IO.FileAccess access, System.IO.FileShare share) { }
 }
 namespace System.IO.Abstractions.TestingHelpers
 {

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ public class FileHandles`
`7`	`7`	`{`
`8`	`8`	`private readonly ConcurrentDictionary<string, ConcurrentDictionary<Guid, (FileAccess access, FileShare share)>> handles = new();`
`9`	`9`
`10`		`- public void TryAddHandle(string path, Guid guid, FileAccess access, FileShare share)`
	`10`	`+ public void AddHandle(string path, Guid guid, FileAccess access, FileShare share)`
`11`	`11`	`{`
`12`	`12`	`var pathHandles = handles.GetOrAdd(`
`13`	`13`	`path,`
Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ public MockFileStream(`
`101`	`101`	`mockFileDataAccessor.AddFile(path, fileData);`
`102`	`102`	`}`
`103`	`103`
`104`		`- mockFileDataAccessor.FileHandles.TryAddHandle(path, guid, access, share);`
	`104`	`+ mockFileDataAccessor.FileHandles.AddHandle(path, guid, access, share);`
`105`	`105`	`this.access = access;`
`106`	`106`	`this.share = share;`
`107`	`107`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3,8 +3,8 @@`
`3`	`3`	`public class FileHandles`
`4`	`4`	`{`
`5`	`5`	`public FileHandles() { }`
	`6`	`+ public void AddHandle(string path, System.Guid guid, System.IO.FileAccess access, System.IO.FileShare share) { }`
`6`	`7`	`public void RemoveHandle(string path, System.Guid guid) { }`
`7`		`- public void TryAddHandle(string path, System.Guid guid, System.IO.FileAccess access, System.IO.FileShare share) { }`
`8`	`8`	`}`
`9`	`9`	`namespace System.IO.Abstractions.TestingHelpers`
`10`	`10`	`{`