Removed unnecessary unit test and introduced MaxContentComparisonSize constant for cleaner comparison logic in MockFileStream.

Author: mistial-dev

src/TestableIO.System.IO.Abstractions.TestingHelpers/MockFileStream.cs

@@ -45,6 +45,9 @@ public NullFileSystemStream() : base(Null, ".", true)
     // This prevents us from overwriting shared content unnecessarily and helps preserve unflushed changes during refresh
     private bool hasUnflushedWrites;
 
+    // Maximum file size for content comparison optimization
+    private const int MaxContentComparisonSize = 4096;
+    
 
     /// <inheritdoc />
     public MockFileStream(
@@ -454,7 +457,7 @@ private bool IsContentIdentical(byte[] sharedContent)
         }
 
         // Quick content comparison for common case where only metadata changed
-        if (sharedContent.Length > 0 && sharedContent.Length <= 4096) // Only check small files
+        if (sharedContent.Length > 0 && sharedContent.Length <= MaxContentComparisonSize) // Only check small files
         {
             var currentPos = Position;
             Position = 0;

tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileStreamTests.cs

@@ -451,41 +451,6 @@ await That(readData[cycle]).IsEqualTo((byte)(cycle + 100))
         }
     }
 
-    [Test]
-    public async Task MockFileStream_SharedContent_VersionOverflowHandling()
-    {
-        var fileSystem = new MockFileSystem();
-        var filename = fileSystem.Path.Combine(fileSystem.Path.GetTempPath(), fileSystem.Path.GetRandomFileName());
-        
-        try
-        {
-            using var file1 = fileSystem.FileStream.New(filename, FileMode.OpenOrCreate, FileAccess.ReadWrite, FileShare.ReadWrite);
-            using var file2 = fileSystem.FileStream.New(filename, FileMode.Open, FileAccess.ReadWrite, FileShare.ReadWrite);
-            
-            // Get reference to file data to manipulate version directly
-            var fileData = fileSystem.GetFile(filename);
-            
-            // Simulate near-overflow condition
-            var reflection = typeof(MockFileData).GetField("contentVersion", 
-                System.Reflection.BindingFlags.NonPublic | System.Reflection.BindingFlags.Instance);
-            reflection?.SetValue(fileData, long.MaxValue - 1);
-            
-            // Write data that will cause version to overflow
-            file1.Write(new byte[] { 1, 2, 3, 4 });
-            file1.Flush();
-            
-            // file2 should still be able to read the data despite version overflow
-            file2.Position = 0;
-            var buffer = new byte[4];
-            var bytesRead = file2.Read(buffer);
-            await That(bytesRead).IsEqualTo(4);
-            await That(buffer).IsEquivalentTo(new byte[] { 1, 2, 3, 4 });
-        }
-        finally
-        {
-            fileSystem.File.Delete(filename);
-        }
-    }
 
     [Test]
     public async Task MockFileStream_Constructor_ReadTypeNotWritable()