Replay will mismatch 100% when Skirmish Game is recorded after RESTART GAME

[xezon]

Prerequisites

• I have searched for similar issues and confirmed this is not a duplicate

Game Version

• Command & Conquer Generals
• Command & Conquer Generals: Zero Hour
• Other (please specify below)

Bug Description

Replay will mismatch 100% when Skirmish Game is recorded after RESTART GAME. Does not happen when not using RESTART GAME.

Tested with and without AI. Tested with and without RTS_DEBUG. Always happens with RESTART GAME.

I suspect it is our bug.

Reproduction Steps

1. Start Skirmish Game as Solo or with AI
2. Press ESC in game
3. Click RESTART GAME button
4. Play a few seconds
5. Exit Game
6. Load Last Replay

Replay will CRC mismatch and not run correctly

Additional Context

No response

[Caball009]

Reproducible with retail executable as well. I'll have a look why this happens.

[Caball009]

GeneralsGameCode/GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/QuitMenu.cpp

Line 243 in c241dbc

InitRandom(0);

The issue is in the line above. On restart it reseeds the seed values with 0, but it doesn't update the game seed. Can be fixed by changing this to either

InitRandom(TheGameInfo->getSeed());

or

TheGameInfo->setSeed(0);
InitRandom(0); // or InitRandom(TheGameInfo->getSeed());

The first version is much better, though, because it retains the original seed value, which improves deterministic behavior.