Skip to content

Commit 3ba0b7a

Browse files
committed
DynamicVoiceChat.java: Remove defensive comment
The constant name is self-documenting. If someone wants to make it as well as other constants in this class configurable later, they can submit a pull request with _actual reasoning_ instead of bikeshedding over a defensive comment. The constant is hardcoded because it's _unlikely_ anyone will want to change it. If that assumption proves wrong, it's trivial to refactor. Signed-off-by: Chris Sdogkos <work@chris-sdogkos.com>
1 parent 7903563 commit 3ba0b7a

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

application/src/main/java/org/togetherjava/tjbot/features/voicechat/DynamicVoiceChat.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,6 @@
3333
public final class DynamicVoiceChat extends VoiceReceiverAdapter {
3434
private static final Logger logger = LoggerFactory.getLogger(DynamicVoiceChat.class);
3535

36-
// @christolis: Unless somebody is willing to make the category name configurable,
37-
// I will leave this here as a constant since I don't see a justification for naming
38-
// this category name into something different.
3936
private static final String ARCHIVE_CATEGORY_NAME = "Voice Channel Archives";
4037
private static final int CLEAN_CHANNELS_AMOUNT = 25;
4138
private static final int MINIMUM_CHANNELS_AMOUNT = 50;

0 commit comments

Comments
 (0)