Skip to content

Commit ee7c19f

Browse files
authored
fix(ObjectPage): disable titleArea interaction if no headerArea (#8121)
1 parent 7c3ae45 commit ee7c19f

File tree

1 file changed

+4
-3
lines changed
  • packages/main/src/components/ObjectPage

1 file changed

+4
-3
lines changed

packages/main/src/components/ObjectPage/index.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ const ObjectPage = forwardRef<ObjectPageDomRef, ObjectPagePropTypes>((props, ref
8484
selectedSectionId ?? firstSectionId,
8585
);
8686
const [tabSelectId, setTabSelectId] = useState<null | string>(null);
87+
const titleAreaInteractive = headerArea && !preserveHeaderStateOnClick;
8788

8889
const isProgrammaticallyScrolled = useRef(false);
8990
const [componentRef, objectPageRef] = useSyncRef(ref);
@@ -512,7 +513,7 @@ const ObjectPage = forwardRef<ObjectPageDomRef, ObjectPagePropTypes>((props, ref
512513

513514
const onTitleClick = (e) => {
514515
e.stopPropagation();
515-
if (!preserveHeaderStateOnClick) {
516+
if (titleAreaInteractive) {
516517
onToggleHeaderContentVisibility(enrichEventWithDetails(e, { visible: headerCollapsed }));
517518
}
518519
};
@@ -667,7 +668,7 @@ const ObjectPage = forwardRef<ObjectPageDomRef, ObjectPagePropTypes>((props, ref
667668
data-component-name="ObjectPageTopHeader"
668669
ref={topHeaderRef}
669670
role={accessibilityAttributes?.objectPageTopHeader?.role}
670-
data-not-clickable={!!preserveHeaderStateOnClick}
671+
data-not-clickable={!titleAreaInteractive}
671672
aria-roledescription={
672673
accessibilityAttributes?.objectPageTopHeader?.ariaRoledescription ?? 'Object Page header'
673674
}
@@ -682,7 +683,7 @@ const ObjectPage = forwardRef<ObjectPageDomRef, ObjectPagePropTypes>((props, ref
682683
cloneElement(titleArea as ReactElement<ObjectPageTitlePropsWithDataAttributes>, {
683684
className: clsx(titleArea?.props?.className),
684685
onToggleHeaderContentVisibility: onTitleClick,
685-
'data-not-clickable': !!preserveHeaderStateOnClick,
686+
'data-not-clickable': !titleAreaInteractive,
686687
'data-header-content-visible': headerArea && headerCollapsed !== true,
687688
_snappedAvatar: (
688689
<CollapsedAvatar

0 commit comments

Comments
 (0)