Skip to content

Commit 63f17e4

Browse files
authored
Converted to using long from for package name (#28)
* Modern client support the long form now. * Reduced noisy output as some messages were still left at "high" importance Co-authored-by: smaillet <25911635+smaillet@users.noreply.github.com>
1 parent f51faec commit 63f17e4

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

New-GeneratedVersionProps.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -339,11 +339,11 @@ try
339339
$propGroupElement.AppendChild($fileVersionElement) | Out-Null
340340

341341
$packageVersionElement = $xmlDoc.CreateElement('PackageVersion')
342-
$packageVersionElement.InnerText = $csemVer.ToString($false,$true) # short form of version
342+
$packageVersionElement.InnerText = $csemVer.ToString($false,$false) # long form of version (No metadata)
343343
$propGroupElement.AppendChild($packageVersionElement) | Out-Null
344344

345345
$productVersionElement = $xmlDoc.CreateElement('ProductVersion')
346-
$productVersionElement.InnerText = $csemVer.ToString($true, $false) # long form of version
346+
$productVersionElement.InnerText = $csemVer.ToString($true, $false) # long form of version (With metadata)
347347
$propGroupElement.AppendChild($productVersionElement) | Out-Null
348348

349349
$assemblyVersionElement = $xmlDoc.CreateElement('AssemblyVersion')

src/Ubiquity.NET.Versioning.Build.Tasks/CreateVersionInfo.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ private void SetFileVersion( int preRelIndex )
168168
orderedVersion += (ulong)PreReleaseFix;
169169
}
170170

171-
Log.LogMessage(MessageImportance.High, "orderedVersion={0}", orderedVersion);
171+
Log.LogMessage(MessageImportance.Low, "orderedVersion={0}", orderedVersion);
172172

173173
bool isCiBuild = !string.IsNullOrWhiteSpace(CiBuildIndex) && !string.IsNullOrWhiteSpace(CiBuildName);
174174
UInt64 fileVersion64 = (orderedVersion << 1) + (isCiBuild ? 1ul : 0ul);
@@ -183,10 +183,10 @@ private void SetFileVersion( int preRelIndex )
183183
rem = (rem - FileVersionMinor.Value) / 65536;
184184
FileVersionMajor = (UInt16)(rem % 65536);
185185

186-
Log.LogMessage(MessageImportance.High, "FileVersionMajor={0}", FileVersionMajor);
187-
Log.LogMessage(MessageImportance.High, "FileVersionMinor={0}", FileVersionMinor);
188-
Log.LogMessage(MessageImportance.High, "FileVersionBuild={0}", FileVersionBuild);
189-
Log.LogMessage(MessageImportance.High, "FileVersionRevision={0}", FileVersionRevision);
186+
Log.LogMessage(MessageImportance.Low, "FileVersionMajor={0}", FileVersionMajor);
187+
Log.LogMessage(MessageImportance.Low, "FileVersionMinor={0}", FileVersionMinor);
188+
Log.LogMessage(MessageImportance.Low, "FileVersionBuild={0}", FileVersionBuild);
189+
Log.LogMessage(MessageImportance.Low, "FileVersionRevision={0}", FileVersionRevision);
190190
}
191191

192192
private bool ValidateInput( )

0 commit comments

Comments
 (0)