Skip to content

Commit 78c5d44

Browse files
committed
Fixed handling of release builds to drop the CI naming
1 parent e28cacd commit 78c5d44

File tree

4 files changed

+11
-10
lines changed

4 files changed

+11
-10
lines changed

BuildVersion.xml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,4 @@ This file is updated on a public release to set the next build that pre-releases
55
BuildMajor = "2"
66
BuildMinor = "0"
77
BuildPatch = "0"
8-
PreReleaseName = "beta"
9-
PreReleaseNumber = "2"
108
/>

Directory.Build.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
-->
6464
<CiBuildName Condition="'$(CiBuildName)'=='' AND '$(IsPullRequestBuild)'=='true'">PRQ</CiBuildName>
6565
<CiBuildName Condition="'$(CiBuildName)'=='' AND '$(IsAutomatedBuild)'=='true'">BLD</CiBuildName>
66-
<CiBuildName Condition="'$(CiBuildName)'==''">ZZZ</CiBuildName>
66+
<CiBuildName Condition="'$(CiBuildName)'=='' AND '$(IsReleaseBuild)'!='true'">ZZZ</CiBuildName>
6767
</PropertyGroup>
6868
<Choose>
6969
<!-- TODO: Split this out so analyzers and common settings are in a common package for easier sharing amongst repositories and projects -->

src/CSemVer.Build.Tasks/CreateVersionInfo.cs

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,15 @@ public class CreateVersionInfo
5151
public override bool Execute( )
5252
{
5353
PrereleaseVersion preReleaseVersion = null;
54-
preReleaseVersion = new PrereleaseVersion( PreReleaseName
55-
, string.IsNullOrWhiteSpace(PreReleaseNumber) ? 0 : Convert.ToInt32( PreReleaseNumber )
56-
, string.IsNullOrWhiteSpace(PreReleaseFix) ? 0 : Convert.ToInt32( PreReleaseFix )
57-
, CiBuildName
58-
, CiBuildIndex
59-
);
54+
if( !string.IsNullOrWhiteSpace( CiBuildName ) )
55+
{
56+
preReleaseVersion = new PrereleaseVersion( PreReleaseName
57+
, string.IsNullOrWhiteSpace( PreReleaseNumber ) ? 0 : Convert.ToInt32( PreReleaseNumber )
58+
, string.IsNullOrWhiteSpace( PreReleaseFix ) ? 0 : Convert.ToInt32( PreReleaseFix )
59+
, CiBuildName
60+
, CiBuildIndex
61+
);
62+
}
6063

6164
var fullVersion = new CSemVer( Convert.ToInt32( BuildMajor )
6265
, Convert.ToInt32( BuildMinor )

src/CSemVer.Build.Tasks/build/CSemVer.Build.Tasks.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
-->
1414
<CiBuildName Condition="'$(CiBuildName)'=='' AND '$(IsPullRequestBuild)'=='true'">PRQ</CiBuildName>
1515
<CiBuildName Condition="'$(CiBuildName)'=='' AND '$(IsAutomatedBuild)'=='true'">BLD</CiBuildName>
16-
<CiBuildName Condition="'$(CiBuildName)'==''">ZZZ</CiBuildName>
16+
<CiBuildName Condition="'$(CiBuildName)'=='' AND '$(IsReleaseBuild)'!='true'">ZZZ</CiBuildName>
1717

1818
<TaskFolder Condition=" '$(MSBuildRuntimeType)' == 'Core' ">netstandard1.6</TaskFolder>
1919
<TaskFolder Condition=" '$(MSBuildRuntimeType)' != 'Core' ">net46</TaskFolder>

0 commit comments

Comments
 (0)