Added build failure checks to tests to prevent continuing tests with a filed build (#36)

Co-authored-by: smaillet <25911635+smaillet@users.noreply.github.com>

Author: smaillet

src/Ubiquity.Versioning.Build.Tasks.UT/AssemblyValidationTests.cs

@@ -83,8 +83,8 @@ public void ValidateRepoAssemblyVersion( string targetFramework)
                 using var collection = new ProjectCollection(globalProperties);
 
                 var (buildResults, props) = Context.CreateTestProjectAndInvokeTestedPackage(targetFramework, collection);
-
                 LogBuildMessages(buildResults.Output);
+                Assert.IsTrue(buildResults.Success);
 
                 string? taskAssembly = buildResults.Creator.ProjectInstance.GetOptionalProperty("_Ubiquity_NET_Versioning_Build_Tasks");
                 Assert.IsNotNull( taskAssembly, "Task assembly property should contain full path to the task DLL (Not NULL)" );

src/Ubiquity.Versioning.Build.Tasks.UT/BuildTaskTests.cs

@@ -43,7 +43,8 @@ public void GoldenPathTest( string targetFramework )
             };
 
             using var collection = new ProjectCollection(globalProperties);
-            var (_, props) = Context.CreateTestProjectAndInvokeTestedPackage(targetFramework, collection);
+            var (buildResults, props) = Context.CreateTestProjectAndInvokeTestedPackage(targetFramework, collection);
+            Assert.IsTrue(buildResults.Success);
 
             // v20.1.4-alpha => 5.44854.3875.59946 [see: https://csemver.org/playground/site/#/]
             // NOTE: CI build is +1 (FileVersionRevision)!
@@ -116,7 +117,8 @@ public void BuildVersionXmlIsUsed( string targetFramework )
 
             using var collection = new ProjectCollection(globalProperties);
 
-            var (_, props) = Context.CreateTestProjectAndInvokeTestedPackage(targetFramework, collection);
+            var (buildResults, props) = Context.CreateTestProjectAndInvokeTestedPackage(targetFramework, collection);
+            Assert.IsTrue(buildResults.Success);
 
             // v20.1.5 => 5.44854.3880.52268 [see: https://csemver.org/playground/site/#/]
             // NOTE: CI build is +1 (FileVersionRevision)!
@@ -193,7 +195,8 @@ public void CiBuildInfoIsProcessedCorrectly( string targetFramework )
             string expectedIndex = parsedBuildTime.ToBuildIndex();
 
             using var collection = new ProjectCollection(globalProperties);
-            var (_, props) = Context.CreateTestProjectAndInvokeTestedPackage(targetFramework, collection);
+            var (buildResults, props) = Context.CreateTestProjectAndInvokeTestedPackage(targetFramework, collection);
+            Assert.IsTrue(buildResults.Success);
 
             // v20.1.5-delta.0.1 => 5.44854.3878.63342 [see: https://csemver.org/playground/site/#/]
             // NOTE: CI build is +1 (FileVersionRevision)!
@@ -275,7 +278,8 @@ public void PreReleaseFixOfZeroNotShownIfNumber( string targetFramework )
             string expectedIndex = parsedBuildTime.ToBuildIndex();
 
             using var collection = new ProjectCollection(globalProperties);
-            var (_, props) = Context.CreateTestProjectAndInvokeTestedPackage(targetFramework, collection);
+            var (buildResults, props) = Context.CreateTestProjectAndInvokeTestedPackage(targetFramework, collection);
+            Assert.IsTrue(buildResults.Success);
 
             // v20.1.5-delta.1 => 5.44854.3878.63540 [see: https://csemver.org/playground/site/#/]
             // NOTE: CI build is +1 (FileVersionRevision)!
@@ -384,7 +388,8 @@ public void ValidateVersionFormatting( bool isPreRelease, bool isCiBuild, bool i
             }
 
             using var collection = new ProjectCollection(globalProperties);
-            var (_, props) = Context.CreateTestProjectAndInvokeTestedPackage("net8.0", collection);
+            var (buildResults, props) = Context.CreateTestProjectAndInvokeTestedPackage("net8.0", collection);
+            Assert.IsTrue(buildResults.Success);
 
             FileVersionQuad expectedFileVersion = ExpectedFileVersion(isPreRelease, isCiBuild);
 

src/Ubiquity.Versioning.Build.Tasks.UT/TestContextExtensions.cs

@@ -60,13 +60,18 @@ internal static VersioningProjectBuildResults CreateTestProjectAndInvokeTestedPa
             var resolveResults = ctx.CreateAndResolveTestProject( targetFramework, action, projectCollection );
             if (!resolveResults.Success)
             {
+                LogBuildErrors(ctx, resolveResults.Output);
                 return new(resolveResults, default);
             }
 
             // Since this project uses an imported target, it won't even exist until AFTER ResolvePackageDependencies[DesignTime|ForBuild] comes along.
             var (result, output) = resolveResults.Creator.ProjectInstance.Build("PrepareVersioningForBuild");
             Assert.IsNotNull( result );
             Assert.IsNotNull( result.ProjectStateAfterBuild );
+            if (result.OverallResult != BuildResultCode.Success)
+            {
+                LogBuildErrors(ctx, output);
+            }
 
             return new(
                 new ProjectBuildResults(resolveResults.Creator, output,  result.OverallResult == BuildResultCode.Success),