From c81b706b820e80f002cbbbd364ece4d05ac5b6d1 Mon Sep 17 00:00:00 2001 From: smaillet <25911635+smaillet@users.noreply.github.com> Date: Thu, 10 Jul 2025 10:33:53 -0700 Subject: [PATCH] Changed release build action to not publish to NuGet - Multiple releases have shown that is problematic to do automated. - Everything else can be "undone" in some form. Publication to NuGet cannot. Thus, EXTREME care needs to come into play for any publication of packages. It can be scripted for simplification, but automated publication is causing too many issues with deprecations and de-listing etc... --- .github/workflows/release-build.yml | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/.github/workflows/release-build.yml b/.github/workflows/release-build.yml index 4f7bc7e..1381cd9 100644 --- a/.github/workflows/release-build.yml +++ b/.github/workflows/release-build.yml @@ -4,7 +4,7 @@ permissions: pages: write packages: write actions: read - + defaults: run: shell: pwsh @@ -67,13 +67,16 @@ jobs: directory: .\BuildOutput\docs branch: gh-pages - - name: Publish packages to NuGet.org - run: | - if( [string]::IsNullOrWhiteSpace('${{secrets.NUGETPUSH_ACCESS_TOKEN}}')) - { - throw "'NUGETPUSH_ACCESS_TOKEN' does not exist, is empty or all whitespace!" - } - dotnet nuget push .\BuildOutput\NuGet\*.nupkg --api-key '${{secrets.NUGETPUSH_ACCESS_TOKEN}}' --source 'https://api.nuget.org/v3/index.json' --skip-duplicate +# no automatic publication of NuGet packages, too much room for mistakes as publication to NuGet +# cannot be undone. The packages must be manually published AFTER a successful GH release process +# as a GH release ca be undone! +# - name: Publish packages to NuGet.org +# run: | +# if( [string]::IsNullOrWhiteSpace('${{secrets.NUGETPUSH_ACCESS_TOKEN}}')) +# { +# throw "'NUGETPUSH_ACCESS_TOKEN' does not exist, is empty or all whitespace!" +# } +# dotnet nuget push .\BuildOutput\NuGet\*.nupkg --api-key '${{secrets.NUGETPUSH_ACCESS_TOKEN}}' --source 'https://api.nuget.org/v3/index.json' --skip-duplicate - name: Create Release if: (!cancelled())