FIX: Redo much of InputSystemUIInputModule (#1082).

Author: Rene Damm

Assets/Tests/InputSystem/APIVerificationTests.cs

@@ -512,6 +512,8 @@ void CheckHTMLFileLinkConsistency(string htmlFile, List<string> unresolvedLinks,
         }
     }
 
+    ////TODO: add verification of *online* links to this; probably prone to instability and maybe they shouldn't fail tests but would
+    ////      be great to have some way of diagnosing links that have gone stale
     [Test]
     [Category("API")]
 #if UNITY_EDITOR_OSX

Assets/Tests/InputSystem/CoreTests_Actions.cs

@@ -739,6 +739,42 @@ public void Actions_CanReadValueFromAction_InCallback()
         Assert.That(receivedValue, Is.EqualTo(1).Within(0.00001));
     }
 
+    [Test]
+    [Category("Actions")]
+    public void Actions_CanReadValueFromAction_InCallback_AsButton()
+    {
+        InputSystem.settings.defaultButtonPressPoint = 0.5f;
+
+        var action = new InputAction(binding: "<Gamepad>/leftTrigger");
+        var gamepad = InputSystem.AddDevice<Gamepad>();
+
+        action.Enable();
+
+        bool? receivedValue = null;
+        action.performed +=
+            ctx =>
+        {
+            Assert.That(receivedValue, Is.Null);
+            receivedValue = ctx.ReadValueAsButton();
+        };
+
+        Set(gamepad.leftTrigger, 0.25f);
+
+        Assert.That(receivedValue, Is.False);
+
+        receivedValue = null;
+
+        Set(gamepad.leftTrigger, 0.75f);
+
+        Assert.That(receivedValue, Is.True);
+
+        receivedValue = null;
+
+        Set(gamepad.leftTrigger, 0.15f);
+
+        Assert.That(receivedValue, Is.False);
+    }
+
     // Some code needs to be able to just generically transfer values from A to B. For this, the
     // generic ReadValue<TValue>() API isn't sufficient.
     [Test]

Assets/Tests/InputSystem/Plugins/UITests.cs

@@ -9,8 +9,23 @@ however, it has to be formatted properly to pass verification tests.
 
 ## [Unreleased]
 
+### Changed
+
+* `InputSystemUIInputModule.trackedDeviceSelect` has been removed. Use `InputSystemUIInputModule.leftClick` instead.
+* `InputSystemUIInputModule.repeatDelay` has been renamed to `moveRepeatDelay` and `repeatRate` has been renamed to `moveRepeatRate`.
+
 ### Fixed
+
 - Fixed CS0109 warning being generated during player build due to use of `new` with the `PlayerInput.camera property`. (case 1174688)
+- Fixed a number of issues in `InputSystemUIInputModule`.
+  * Fixed GC heap garbage when click-dragging.
+  * Fixed number of pointer states growing indefinitely if OS did not reuse touch IDs.
+  * Fixed `lastPress` on `PointerEventData` getting lost.
+  * Fixed button press-and-release happening in same frame resulting in no UI input.
+  * Fixed clicks initiated from non-pointer devices resulting in pointer inputs with `(0,0)` positions.
+  * Fixed huge screen deltas on pointer events from tracked devices.
+  * Fixed touch input not sending pointer exit events ([case 1213550](https://issuetracker.unity3d.com/issues/input-system-onpointerexit-does-not-work)).
+- Fixed `TrackedDeviceRaycaster` not setting `screenPosition` in `RaycastResult`.
 
 #### Actions
 
@@ -20,6 +35,16 @@ however, it has to be formatted properly to pass verification tests.
 - `PressInteraction` no longer misses the next button press if it gets reset from within the `performed` callback ([case 1205285](https://issuetracker.unity3d.com/issues/inputsystem-problem-with-button-state-after-deactivating-and-reactivating-an-action-map)).
 - `InputBinding.DisplayStringOptions.DontIncludeInteractions` is now properly respected.
 - Reading the value of a composite binding no longer causes processors from the last active part binding to be applied rather than the processors of the composite itself, if any ([case 1207082](https://issuetracker.unity3d.com/issues/input-system-invert-processors-have-no-effect-on-the-inputaction-dot-callbackcontext-value)).
+- Fixed `InputSystem.onActionChange` getting invoked too many times on binding changes.
+
+### Added
+
+- `InputSystemUIInputModule` now sends pointer events using a new `ExtendedPointerEventData` instead of using the base `PointerEventData` class. This surfaces additional input data in pointer events.
+- Added `InputSystemUIInputModule.pointerBehavior` to allow dictating how the UI will resolve concurrent input from multiple pointers.
+
+####
+
+- Added `InputAction.CallbackContext.ReadValueAsButton`.
 
 ## [1.0.0-preview.5] - 2020-02-14
 

Packages/com.unity.inputsystem/CHANGELOG.md

@@ -26,3 +26,5 @@ To fully switch from the old Input Manager to the new Input System for a Project
 ![Switch Active Input Handling](Images/ActiveInputHandling.png)
 
 >__Note__: You must restart the Unity Editor before this setting takes effect.
+
+When the new input backends are enabled, the `ENABLE_INPUT_SYSTEM=1` C# `#define` is added to builds. Similarly, when the old input backends are enabled, the `ENABLE_LEGACY_INPUT_MANAGER=1` C# `#define` is added. Because both can be enabled at the same time, it is possible for __both__ defines to be 1 at the same time.

Packages/com.unity.inputsystem/Documentation~/Images/InputSystemUIInputModule.png

@@ -8,6 +8,10 @@ The following is a list of known limitations that the Input System currently has
 * The Input System cannot generate input for IMGUI or UIElements.
 * The Input System does not yet support the new 2019.3 mode where domain reloads are disabled when entering play mode.
 
+### uGUI
+
+* After enabling, the UI will not react to a pointer's position until the position is changed.
+
 ## Device support
 
 * (Windows) Mouse input from remote desktop connections does not come through properly.

Packages/com.unity.inputsystem/Documentation~/Images/TrackedDeviceRaycaster.png

@@ -4,6 +4,21 @@ This guide provides a list of APIs in `UnityEngine.Input` (and other related API
 
 >__Note__: All of the new APIs are in the `UnityEngine.InputSystem` namespace. The namespace is omitted here for brevity. `UnityEngine.InputSystem` is referenced in full for easy disambiguation.
 
+Note that it is possible to have code for the old and the new input system at the same time using conditional compilation. When the new input system is enabled in the player preferences (see [here](./Installation.md#enabling-the-new-input-backends)), the `ENABLE_INPUT_SYSTEM` preprocessor directive is available.
+
+```CSharp
+#if ENABLE_INPUT_SYSTEM
+    // New input system backends are enabled.
+#endif
+
+#if ENABLE_LEGACY_INPUT_MANAGER
+    // Old input backends are enabled.
+#endif
+
+    // NOTE: Both can be true at the same time as it is possible to select "Both"
+    //       under "Active Input Handling".
+```
+
 ## [`UnityEngine.Input`](https://docs.unity3d.com/ScriptReference/Input.html)
 
 ### [`UnityEngine.Input.acceleration`](https://docs.unity3d.com/ScriptReference/Input-acceleration.html)