FIX: EditorWindow space not appearing to work (case 1191859, #938).

Author: Rene Damm

Assets/Samples/EditorWindowDemo.meta

@@ -0,0 +1,4 @@
+{
+  "displayName": "EditorWindow Demo",
+  "description": "A simple example of how to use the input system from within EditorWindow code."
+} 

Assets/Samples/EditorWindowDemo/.sample.json

@@ -0,0 +1,45 @@
+using UnityEditor;
+using UnityEngine.InputSystem;
+
+public class EditorWindowDemo : EditorWindow
+{
+    [MenuItem("Window/Input System Editor Window Demo")]
+    public static void Open()
+    {
+        GetWindow<EditorWindowDemo>();
+    }
+
+    protected void OnGUI()
+    {
+        // Grab the current pointer device (mouse, pen, touchscreen).
+        var pointer = Pointer.current;
+        if (pointer == null)
+            return;
+
+        // Pointer positions should automatically be converted to EditorWindow space of
+        // the current window. Unlike player window coordinates, this uses UI window space,
+        // i.e. Y goes top down rather than bottom up.
+        var position = pointer.position.ReadValue();
+        var pressure = pointer.pressure.ReadValue();
+        var contact = pointer.press.isPressed;
+
+        EditorGUILayout.LabelField($"Device: {pointer}");
+        EditorGUILayout.LabelField($"Position: {position}");
+        EditorGUILayout.LabelField($"Pressure: {pressure}");
+        EditorGUILayout.LabelField($"Contact?: {contact}");
+
+        // Just for kicks, also read out some data from the currently used gamepad (if any).
+        var gamepad = Gamepad.current;
+        if (gamepad != null)
+        {
+            EditorGUILayout.Space();
+            EditorGUILayout.LabelField($"Gamepad Left Stick: {gamepad.leftStick.ReadValue()}");
+            EditorGUILayout.LabelField($"Gamepad Right Stick: {gamepad.leftStick.ReadValue()}");
+        }
+
+        // We want to constantly refresh to show the current values so trigger
+        // another refresh right away. Otherwise, the values we show will only
+        // update periodically.
+        Repaint();
+    }
+}

Assets/Samples/EditorWindowDemo/Editor.meta

@@ -0,0 +1,3 @@
+This is a simple example of how to use the input system in EditorWindow code.
+
+For more details see the [documentation](https://docs.unity3d.com/Packages/com.unity.inputsystem@latest/index.html?subfolder=/manual/UseInEditor.html).

Assets/Samples/EditorWindowDemo/Editor/EditorWindowDemo.cs

@@ -9,6 +9,10 @@ however, it has to be formatted properly to pass verification tests.
 
 ## [1.0.0-preview.2] - 2999-11-11
 
+### Changed
+
+- Automatic conversion of window coordinates in `EditorWindow` code is now performed regardless of focus or the setting of `Lock Input to Game View` in the input debugger.
+
 ### Fixed
 
 - Fixed touch taps triggering when they shouldn't on Android.
@@ -30,6 +34,10 @@ however, it has to be formatted properly to pass verification tests.
 - Fixed `ArgumentNullException` when adding a device and a binding in an action map had an empty path (case 1187163).
 - Fixed bindings that are not associated with any control scheme not getting enabled with other control schemes as they should.
 
+### Added
+
+- Added a new `EditorWindow Demo` sample that illustrates how to use the input system in editor UI code.
+
 ## [1.0.0-preview.1] - 2019-10-11
 
 ### Changed

Assets/Samples/EditorWindowDemo/Editor/EditorWindowDemo.cs.meta

@@ -2,7 +2,6 @@
 using System.ComponentModel;
 using UnityEngine.InputSystem.LowLevel;
 using UnityEditor;
-using UnityEngine.InputSystem.Editor;
 
 namespace UnityEngine.InputSystem.Processors
 {
@@ -27,10 +26,12 @@ public override Vector2 Process(Vector2 value, InputControl control)
             if (control == null)
                 throw new System.ArgumentNullException(nameof(control));
 
-            // Don't convert to EditorWindowSpace if input is going to game view.
-            if (InputEditorUserSettings.lockInputToGameView ||
-                (EditorApplication.isPlaying && Application.isFocused))
-                return value;
+            // We go and fire trigger QueryEditorWindowCoordinatesCommand regardless
+            // of whether we are currently in EditorWindow code or not. The expectation
+            // here is that the underlying editor code is in a better position than us
+            // to judge whether the conversion should be performed or not. In native code,
+            // the IOCTL implementations will early out if they detect that the current
+            // EditorWindow is in fact a game view.
 
             if (Mouse.s_PlatformMouseDevice != null)
             {

Assets/Samples/EditorWindowDemo/README.md

@@ -7,6 +7,9 @@
 using UnityEditor.IMGUI.Controls;
 using UnityEngine.Profiling;
 
+////TODO: switch to ReadValueFromState (the current value reading code dates back to very early versions of the input system)
+////      (note that doing so will have an impact on mouse coordinates which then will go through EditorWindowSpaceProcessor)
+
 ////TODO: make control values editable (create state events from UI and pump them into the system)
 
 ////TODO: show processors attached to controls
@@ -228,7 +231,6 @@ private bool ReadState(InputControl control, out GUIContent value, out GUIConten
             {
                 if (stateBuffer != null)
                 {
-                    ////TODO: switch to ReadValueFromState
                     var text = ReadRawValueAsString(control, stateBuffer);
                     if (text != null)
                         value = new GUIContent(text);