FIX: ArgumentExceptions 'Invalid user' when re-enabling PlayerInputs (case 1198889, #1030).

Author: Rene Damm

Assets/Tests/InputSystem/Plugins/UserTests.cs

@@ -481,18 +481,20 @@ public void Users_CanUnpairDevicesAndRemoveUser()
         var user = InputUser.PerformPairingWithDevice(gamepad1);
         InputUser.PerformPairingWithDevice(gamepad2, user: user);
 
+        var originalUser = user;
         user.UnpairDevicesAndRemoveUser();
 
+        Assert.That(user, Is.EqualTo(default(InputUser)));
         Assert.That(user.valid, Is.False);
         Assert.That(InputUser.all, Is.Empty);
         Assert.That(receivedChanges, Is.EquivalentTo(new[]
         {
-            new UserChange(user, InputUserChange.Added),
-            new UserChange(user, InputUserChange.DevicePaired, gamepad1),
-            new UserChange(user, InputUserChange.DevicePaired, gamepad2),
-            new UserChange(user, InputUserChange.DeviceUnpaired, gamepad1),
-            new UserChange(user, InputUserChange.DeviceUnpaired, gamepad2),
-            new UserChange(user, InputUserChange.Removed),
+            new UserChange(originalUser, InputUserChange.Added),
+            new UserChange(originalUser, InputUserChange.DevicePaired, gamepad1),
+            new UserChange(originalUser, InputUserChange.DevicePaired, gamepad2),
+            new UserChange(originalUser, InputUserChange.DeviceUnpaired, gamepad1),
+            new UserChange(originalUser, InputUserChange.DeviceUnpaired, gamepad2),
+            new UserChange(originalUser, InputUserChange.Removed),
         }));
     }
 

Packages/com.unity.inputsystem/CHANGELOG.md

@@ -11,6 +11,9 @@ however, it has to be formatted properly to pass verification tests.
 
 ### Fixed
 
+#### Actions
+
+- "Invalid user" `ArgumentException` when turning the same `PlayerInput` on and off ([case 1198889](https://issuetracker.unity3d.com/issues/input-system-package-argumentexception-invalid-user-error-is-thrown-when-the-callback-disables-game-object-with-playerinput)).
 - The list of device requirements for a control scheme in the action editor no longer displays devices with their internal layout name rather than their external display name.
 
 ## [1.0.0-preview.4] - 2020-01-24

Packages/com.unity.inputsystem/InputSystem/Plugins/Users/InputUser.cs

@@ -691,6 +691,8 @@ public void UnpairDevicesAndRemoveUser()
 
             var userIndex = index;
             RemoveUser(userIndex);
+
+            m_Id = default;
         }
 
         /// <summary>