FIX: Actions stuck in Performed after multiple simultaneous key presses (case 1295535, #1257).

Author: jimon

Assets/Tests/InputSystem/CoreTests_Actions.cs

@@ -7391,6 +7391,32 @@ public void Actions_OnActionWithMultipleBindings_IfGroupIsAmbiguous_OverridesAll
         Assert.That(action.bindings[1].overridePath, Is.EqualTo("/gamepad/buttonSouth"));
     }
 
+    [Test]
+    [Category("Actions")]
+    public void Actions_OnActionWithMultipleBindings_CanTransitionFromOneActuatedControlToAnother()
+    {
+        var keyboard = InputSystem.AddDevice<Keyboard>();
+        var wasCanceled = false;
+        var action = new InputAction("test", InputActionType.Button);
+        action.canceled += _ => wasCanceled = true;
+        action.AddBinding("<Keyboard>/s");
+        action.AddBinding("<Keyboard>/a");
+        action.Enable();
+
+        Press(keyboard.sKey);
+        Assert.That(action.phase, Is.EqualTo(InputActionPhase.Performed));
+
+        Press(keyboard.aKey);
+        Assert.That(action.phase, Is.EqualTo(InputActionPhase.Performed));
+
+        Release(keyboard.sKey);
+        Assert.That(action.phase, Is.EqualTo(InputActionPhase.Performed));
+
+        Release(keyboard.aKey);
+        Assert.That(action.phase, Is.EqualTo(InputActionPhase.Waiting));
+        Assert.That(wasCanceled, Is.True);
+    }
+
     [Test]
     [Category("Actions")]
     public void Actions_CanRestoreDefaultsAfterOverridingBinding()

Packages/com.unity.inputsystem/CHANGELOG.md

@@ -24,6 +24,8 @@ however, it has to be formatted properly to pass verification tests.
   * In our own measurements, `InputUser.OnEvent` is >9 times faster than before and `RebindingOperation.OnEvent` is ~2.5 times faster.
 - Fixed PS4 controller not recognized on Mac when connected over Bluetooth ([case 1286449](https://issuetracker.unity3d.com/issues/input-system-dualshock-4-zct1e-dualshock-2-v1-devices-are-not-fully-recognised-over-bluetooth)).
 - Fixed restart prompt after package installation not appearing on Unity 2020.2+ ([case 1292513](https://issuetracker.unity3d.com/issues/input-system-after-package-install-the-update-slash-switch-and-restart-prompt-does-not-appear)).
+- Fixed action with multiple bindings getting stuck in `Performed` state when two or more controls are pressed at the same time ([case 1295535](https://issuetracker.unity3d.com/issues/input-system-not-registering-multiple-inputs)).
+  * Regression introduced in 1.1-preview.2.
 
 ### Added
 

Packages/com.unity.inputsystem/InputSystem/Actions/InputActionState.cs

@@ -1451,6 +1451,15 @@ private void ProcessDefaultInteraction(ref TriggerState trigger, int actionIndex
                         var threshold = pressPoint * ButtonControl.s_GlobalDefaultButtonReleaseThreshold;
                         if (actuation <= threshold)
                             ChangePhaseOfAction(InputActionPhase.Canceled, ref trigger);
+                        else
+                        {
+                            // ShouldIgnoreControlStateChange may have switched one from control to another,
+                            // so make sure we update the trigger state here regardless of whether we changed
+                            // phase or not.
+                            actionState->controlIndex = trigger.controlIndex;
+                            actionState->bindingIndex = trigger.bindingIndex;
+                            actionState->magnitude = actuation;
+                        }
                     }
                     else if (actionState->isPassThrough)
                     {