Make sure tasks controlled by the Downloader can be cancelled

shana · shana · commit 4238c8e3e896 · 2020-01-01T11:35:05.000-07:00
diff --git a/src/com.unity.editor.tasks/Editor/Tasks/DownloadTask.cs b/src/com.unity.editor.tasks/Editor/Tasks/DownloadTask.cs
@@ -289,7 +289,7 @@ public static bool Download(ILogging logger,
 
 		public void QueueDownload(UriString url, string targetDirectory, string filename = null, int retryCount = 0)
 		{
-			var download = new DownloadTask(TaskManager, url, targetDirectory, filename, retryCount);
+			var download = new DownloadTask(TaskManager, url, targetDirectory, filename, retryCount, Token);
 			download.OnStart += t => OnDownloadStart?.Invoke(((DownloadTask)t).Url);
 			download.OnEnd += (t, res, s, ex) => {
 				if (s)

Original file line number	Diff line number	Diff line change
`@@ -289,7 +289,7 @@ public static bool Download(ILogging logger,`
`289`	`289`
`290`	`290`	`public void QueueDownload(UriString url, string targetDirectory, string filename = null, int retryCount = 0)`
`291`	`291`	`{`
`292`		`- var download = new DownloadTask(TaskManager, url, targetDirectory, filename, retryCount);`
	`292`	`+ var download = new DownloadTask(TaskManager, url, targetDirectory, filename, retryCount, Token);`
`293`	`293`	`download.OnStart += t => OnDownloadStart?.Invoke(((DownloadTask)t).Url);`
`294`	`294`	`download.OnEnd += (t, res, s, ex) => {`
`295`	`295`	`if (s)`