Replicate HLAPI patch in https://bitbucket.org/Unity-Technologies/networking/pull-requests/21/cache-animator-parameters-to-avoid/diff

angusmf · angusmf · commit 39042c498707 · 2018-03-05T09:13:22.000-07:00
diff --git a/MLAPI/MonoBehaviours/Prototyping/NetworkedAnimator.cs b/MLAPI/MonoBehaviours/Prototyping/NetworkedAnimator.cs
@@ -245,12 +245,13 @@ internal void HandleAnimTriggerMsg(int clientId, byte[] data)
 
         void WriteParameters(BinaryWriter writer, bool autoSend)
         {
-            for (int i = 0; i < m_Animator.parameters.Length; i++)
+            AnimatorControllerParameter[] parameters = m_Animator.parameters;
+            for (int i = 0; i < parameters.Length; i++)
             {
                 if (autoSend && !GetParameterAutoSend(i))
                     continue;
 
-                AnimatorControllerParameter par = m_Animator.parameters[i];
+                AnimatorControllerParameter par = parameters[i];
                 if (par.type == AnimatorControllerParameterType.Int)
                 {
                     writer.Write((uint)m_Animator.GetInteger(par.nameHash));
@@ -276,12 +277,13 @@ void WriteParameters(BinaryWriter writer, bool autoSend)
 
         void ReadParameters(BinaryReader reader, bool autoSend)
         {
-            for (int i = 0; i < m_Animator.parameters.Length; i++)
+            AnimatorControllerParameter[] parameters = m_Animator.parameters;
+            for (int i = 0; i < parameters.Length; i++)
             {
                 if (autoSend && !GetParameterAutoSend(i))
                     continue;
 
-                AnimatorControllerParameter par = m_Animator.parameters[i];
+                AnimatorControllerParameter par = parameters[i];
                 if (par.type == AnimatorControllerParameterType.Int)
                 {
                     int newValue = (int)reader.ReadUInt32();

Original file line number	Diff line number	Diff line change
`@@ -245,12 +245,13 @@ internal void HandleAnimTriggerMsg(int clientId, byte[] data)`
`245`	`245`
`246`	`246`	`void WriteParameters(BinaryWriter writer, bool autoSend)`
`247`	`247`	`{`
`248`		`- for (int i = 0; i < m_Animator.parameters.Length; i++)`
	`248`	`+ AnimatorControllerParameter[] parameters = m_Animator.parameters;`
	`249`	`+ for (int i = 0; i < parameters.Length; i++)`
`249`	`250`	`{`
`250`	`251`	`if (autoSend && !GetParameterAutoSend(i))`
`251`	`252`	`continue;`
`252`	`253`
`253`		`- AnimatorControllerParameter par = m_Animator.parameters[i];`
	`254`	`+ AnimatorControllerParameter par = parameters[i];`
`254`	`255`	`if (par.type == AnimatorControllerParameterType.Int)`
`255`	`256`	`{`
`256`	`257`	`writer.Write((uint)m_Animator.GetInteger(par.nameHash));`
`@@ -276,12 +277,13 @@ void WriteParameters(BinaryWriter writer, bool autoSend)`
`276`	`277`
`277`	`278`	`void ReadParameters(BinaryReader reader, bool autoSend)`
`278`	`279`	`{`
`279`		`- for (int i = 0; i < m_Animator.parameters.Length; i++)`
	`280`	`+ AnimatorControllerParameter[] parameters = m_Animator.parameters;`
	`281`	`+ for (int i = 0; i < parameters.Length; i++)`
`280`	`282`	`{`
`281`	`283`	`if (autoSend && !GetParameterAutoSend(i))`
`282`	`284`	`continue;`
`283`	`285`
`284`		`- AnimatorControllerParameter par = m_Animator.parameters[i];`
	`286`	`+ AnimatorControllerParameter par = parameters[i];`
`285`	`287`	`if (par.type == AnimatorControllerParameterType.Int)`
`286`	`288`	`{`
`287`	`289`	`int newValue = (int)reader.ReadUInt32();`