Changed syncedVar behaviour on initial spawn

TwoTenPvP · TwoTenPvP · commit 5a8eb76c4801 · 2018-05-09T14:40:28.000+02:00
SyncedVars no longer gets synced to objects that are not observerd on spawn
diff --git a/MLAPI.sln b/MLAPI.sln
@@ -9,28 +9,28 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "MLAPI-Editor", "MLAPI-Edito
 EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
+		CI|Any CPU = CI|Any CPU
 		Debug|Any CPU = Debug|Any CPU
 		Development|Any CPU = Development|Any CPU
 		Release|Any CPU = Release|Any CPU
-		CI|Any CPU = CI|Any CPU
 	EndGlobalSection
 	GlobalSection(ProjectConfigurationPlatforms) = postSolution
+		{EE431720-A9ED-43DC-9E74-10B693816D38}.CI|Any CPU.ActiveCfg = CI|Any CPU
+		{EE431720-A9ED-43DC-9E74-10B693816D38}.CI|Any CPU.Build.0 = CI|Any CPU
 		{EE431720-A9ED-43DC-9E74-10B693816D38}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
 		{EE431720-A9ED-43DC-9E74-10B693816D38}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{EE431720-A9ED-43DC-9E74-10B693816D38}.Development|Any CPU.ActiveCfg = Development|Any CPU
 		{EE431720-A9ED-43DC-9E74-10B693816D38}.Development|Any CPU.Build.0 = Development|Any CPU
 		{EE431720-A9ED-43DC-9E74-10B693816D38}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{EE431720-A9ED-43DC-9E74-10B693816D38}.Release|Any CPU.Build.0 = Release|Any CPU
-		{EE431720-A9ED-43DC-9E74-10B693816D38}.CI|Any CPU.ActiveCfg = CI|Any CPU
-		{EE431720-A9ED-43DC-9E74-10B693816D38}.CI|Any CPU.Build.0 = CI|Any CPU
+		{A45DBD43-D640-4562-9F24-6745269CEDF7}.CI|Any CPU.ActiveCfg = Release|Any CPU
+		{A45DBD43-D640-4562-9F24-6745269CEDF7}.CI|Any CPU.Build.0 = Release|Any CPU
 		{A45DBD43-D640-4562-9F24-6745269CEDF7}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
 		{A45DBD43-D640-4562-9F24-6745269CEDF7}.Debug|Any CPU.Build.0 = Debug|Any CPU
 		{A45DBD43-D640-4562-9F24-6745269CEDF7}.Development|Any CPU.ActiveCfg = Debug|Any CPU
 		{A45DBD43-D640-4562-9F24-6745269CEDF7}.Development|Any CPU.Build.0 = Debug|Any CPU
 		{A45DBD43-D640-4562-9F24-6745269CEDF7}.Release|Any CPU.ActiveCfg = Release|Any CPU
 		{A45DBD43-D640-4562-9F24-6745269CEDF7}.Release|Any CPU.Build.0 = Release|Any CPU
-		{A45DBD43-D640-4562-9F24-6745269CEDF7}.CI|Any CPU.ActiveCfg = CI|Any CPU
-		{A45DBD43-D640-4562-9F24-6745269CEDF7}.CI|Any CPU.Build.0 = CI|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE
diff --git a/MLAPI/MonoBehaviours/Core/NetworkingManager.cs b/MLAPI/MonoBehaviours/Core/NetworkingManager.cs
@@ -1162,7 +1162,8 @@ internal void HandleApproval(uint clientId, bool approved, Vector3 position, Qua
                             writer.WriteFloat(pair.Value.transform.rotation.eulerAngles.y);
                             writer.WriteFloat(pair.Value.transform.rotation.eulerAngles.z);
 
-                            pair.Value.WriteFormattedSyncedVarData(writer);
+                            if (pair.Value.observers.Contains(clientId))
+                                pair.Value.WriteFormattedSyncedVarData(writer);
                         }
                     }
 
diff --git a/MLAPI/NetworkingManagerComponents/Core/InternalMessageHandler.Receive.cs b/MLAPI/NetworkingManagerComponents/Core/InternalMessageHandler.Receive.cs
@@ -103,13 +103,13 @@ internal static void HandleConnectionApproved(uint clientId, BitReader reader, i
 
                     if (isPlayerObject)
                     {
-                        GameObject go = SpawnManager.SpawnPlayerObject(ownerId, networkId, new Vector3(xPos, yPos, zPos), Quaternion.Euler(xRot, yRot, zRot), reader);
+                        GameObject go = SpawnManager.SpawnPlayerObject(ownerId, networkId, new Vector3(xPos, yPos, zPos), Quaternion.Euler(xRot, yRot, zRot), visible ? reader : null);
                         go.GetComponent<NetworkedObject>().SetLocalVisibility(visible);
                     }
                     else
                     {
                         GameObject go = SpawnManager.SpawnPrefabIndexClient(prefabId, networkId, ownerId,
-                            new Vector3(xPos, yPos, zPos), Quaternion.Euler(xRot, yRot, zRot), reader);
+                            new Vector3(xPos, yPos, zPos), Quaternion.Euler(xRot, yRot, zRot), visible ? reader : null);
 
                         go.GetComponent<NetworkedObject>().SetLocalVisibility(visible);
                         go.GetComponent<NetworkedObject>().sceneObject = sceneObject;

Original file line number	Diff line number	Diff line change
`@@ -1162,7 +1162,8 @@ internal void HandleApproval(uint clientId, bool approved, Vector3 position, Qua`
`1162`	`1162`	`writer.WriteFloat(pair.Value.transform.rotation.eulerAngles.y);`
`1163`	`1163`	`writer.WriteFloat(pair.Value.transform.rotation.eulerAngles.z);`
`1164`	`1164`
`1165`		`- pair.Value.WriteFormattedSyncedVarData(writer);`
	`1165`	`+ if (pair.Value.observers.Contains(clientId))`
	`1166`	`+ pair.Value.WriteFormattedSyncedVarData(writer);`
`1166`	`1167`	`}`
`1167`	`1168`	`}`
`1168`	`1169`
Original file line number	Diff line number	Diff line change
`@@ -103,13 +103,13 @@ internal static void HandleConnectionApproved(uint clientId, BitReader reader, i`
`103`	`103`
`104`	`104`	`if (isPlayerObject)`
`105`	`105`	`{`
`106`		`- GameObject go = SpawnManager.SpawnPlayerObject(ownerId, networkId, new Vector3(xPos, yPos, zPos), Quaternion.Euler(xRot, yRot, zRot), reader);`
	`106`	`+ GameObject go = SpawnManager.SpawnPlayerObject(ownerId, networkId, new Vector3(xPos, yPos, zPos), Quaternion.Euler(xRot, yRot, zRot), visible ? reader : null);`
`107`	`107`	`go.GetComponent<NetworkedObject>().SetLocalVisibility(visible);`
`108`	`108`	`}`
`109`	`109`	`else`
`110`	`110`	`{`
`111`	`111`	`GameObject go = SpawnManager.SpawnPrefabIndexClient(prefabId, networkId, ownerId,`
`112`		`- new Vector3(xPos, yPos, zPos), Quaternion.Euler(xRot, yRot, zRot), reader);`
	`112`	`+ new Vector3(xPos, yPos, zPos), Quaternion.Euler(xRot, yRot, zRot), visible ? reader : null);`
`113`	`113`
`114`	`114`	`go.GetComponent<NetworkedObject>().SetLocalVisibility(visible);`
`115`	`115`	`go.GetComponent<NetworkedObject>().sceneObject = sceneObject;`