Began replacing BitWriter & Reader with Streams

Author: TwoTenPvP

MLAPI/Data/AttributeMessageMode.cs

@@ -1,4 +1,5 @@
 using System;
+using System.IO;
 using System.Reflection;
 using MLAPI.NetworkingManagerComponents.Binary;
 
@@ -12,7 +13,7 @@ public enum AttributeMessageMode
         WovenEightByte
     }
 
-    public delegate void RpcDelegate(uint clientId, BitReader reader);
+    public delegate void RpcDelegate(uint clientId, Stream stream);
 
     public class ReflectionMehtod
     {
@@ -33,12 +34,12 @@ public ReflectionMehtod(MethodInfo methodInfo)
             }
         }
 
-        public void Invoke(object instance, BitReader reader)
+        public void Invoke(object instance, Stream stream)
         {
+            BitReader reader = new BitReader(stream);
             for (int i = 0; i < parameterTypes.Length; i++)
             {
-                //TODO: BitReader ReadType
-                parameterRefs[i] = reader.ReadObject(parameterTypes[i]);
+                parameterRefs[i] = reader.ReadObjectPacked(parameterTypes[i]);
             }
 
             method.Invoke(instance, parameterRefs);

MLAPI/Data/FieldType.cs

@@ -157,6 +157,7 @@ private void Sort()
         /// Returns a base64 encoded version of the config
         /// </summary>
         /// <returns></returns>
+        /*
         public string ToBase64()
         {
             NetworkConfig config = this;
@@ -282,6 +283,7 @@ public void FromBase64(string base64, bool createDummyObject = false)
                 config.AttributeMessageMode = (AttributeMessageMode)reader.ReadBits(3);
             }
         }
+        */
 
         private ulong? ConfigHash = null;
         /// <summary>
@@ -296,9 +298,10 @@ public ulong GetConfig(bool cache = true)
 
             Sort();
 
-            using (BitWriter writer = BitWriter.Get())
+            using (PooledBitStream stream = PooledBitStream.Get())
             {
-                writer.WriteUShort(ProtocolVersion);
+                BitWriter writer = new BitWriter(stream);
+                writer.WriteUInt16Packed(ProtocolVersion);
                 writer.WriteString(MLAPIConstants.MLAPI_PROTOCOL_VERSION);
 
                 for (int i = 0; i < Channels.Count; i++)
@@ -331,10 +334,10 @@ public ulong GetConfig(bool cache = true)
                 // Returns a 160 bit / 20 byte / 5 int checksum of the config
                 if (cache)
                 {
-                    ConfigHash = writer.Finalize().GetStableHash64();
+                    ConfigHash = stream.ToArray().GetStableHash64();
                     return ConfigHash.Value;
                 }
-                return writer.Finalize().GetStableHash64();
+                return stream.ToArray().GetStableHash64();
             }
         }