Changed observer API

The observer set in OnRebuildObservers is no longer cleared before it's passed over

Author: TwoTenPvP

MLAPI/MonoBehaviours/Core/NetworkedObject.cs

@@ -136,8 +136,8 @@ public bool isSpawned
         /// <summary>
         /// The current clients observing the object
         /// </summary>
-        public HashSet<uint> observers = new HashSet<uint>();
-        private HashSet<uint> previousObservers = new HashSet<uint>();
+        public readonly HashSet<uint> observers = new HashSet<uint>();
+        private readonly HashSet<uint> previousObservers = new HashSet<uint>();
 
         internal void RebuildObservers(uint? clientId = null)
         {
@@ -162,7 +162,6 @@ internal void RebuildObservers(uint? clientId = null)
                 previousObservers.Clear();
                 foreach (var item in observers)
                     previousObservers.Add(item);
-                observers.Clear();
                 bool update = false;
                 for (int i = 0; i < childNetworkedBehaviours.Count; i++)
                 {
@@ -199,6 +198,7 @@ internal void RebuildObservers(uint? clientId = null)
                     foreach (var item in previousObservers)
                         observers.Add(item);
                 }
+                previousObservers.Clear();
             }
         }
 

MLAPI/MonoBehaviours/Prototyping/NetworkedProximity.cs

@@ -86,6 +86,13 @@ public override bool OnCheckObserver(uint newClientId)
         /// <returns>Wheter or not we changed anything</returns>
         public override bool OnRebuildObservers(HashSet<uint> observers)
         {
+            // This implementation is an example. 
+            // Not efficient. We remove all old observers as the API doesn't clear them for us.
+            // The reason it's not cleared is so that you don't have to iterate over your things if you simply
+            // Have an event driven system where you want to remove a player. Ex if they leave a zone
+            observers.Clear();
+            observers = new HashSet<uint>();
+
             if (ForceHidden)
             {
                 // ensure player can still see themself