Commit c63202f
authored
chore: Move ChangeOwnership OwnershipMessageTypeFlags to an enum (#3648)
## Purpose of this PR
Swaps the `m_OwnershipMessageTypeFlags` from a bitfield to an enum as
the field is being used like an enum.
### Jira ticket
_Link to related jira ticket ([Use the smart
commits](https://support.atlassian.com/bitbucket-cloud/docs/use-smart-commits/)).
Short version (e.g. MTT-123) also works and gets auto-linked_
### Changelog
[//]: # (updated with all public facing changes - API changes, UI/UX
changes, behaviour changes, bug fixes. Remove if not relevant.)
- Changed: Internal representation of ChangeOwnershipMessage now uses an
enum rather than a bitfield.
## Documentation
- No documentation changes or additions were necessary.
## Testing & QA (How your changes can be verified during release
Playtest)
Can be playtested with the Astroids Ownership demos.
<!-- Add any performance testing results here if relevant. -->
### Functional Testing
[//]: # (If checked, List manual tests that have been performed.)
_Manual testing :_
- [ ] `Manual testing done`
_Automated tests:_
- [x] `Covered by existing automated tests`
- [ ] `Covered by new automated tests`
_Does the change require QA team to:_
- [ ] `Review automated tests`?
- [ ] `Execute manual tests`?
- [ ] `Provide feedback about the PR`?
If any boxes above are checked the QA team will be automatically added
as a PR reviewer.
## Backports
Performance improvement is only required to be in 2.x1 parent 2275c2f commit c63202f
File tree
5 files changed
+338
-309
lines changed- com.unity.netcode.gameobjects
- Runtime
- Core
- Messaging/Messages
- Spawning
- Tests/Runtime
- DistributedAuthority
- TestHelpers
5 files changed
+338
-309
lines changedLines changed: 8 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
785 | 785 | | |
786 | 786 | | |
787 | 787 | | |
| 788 | + | |
788 | 789 | | |
789 | 790 | | |
790 | 791 | | |
791 | 792 | | |
792 | 793 | | |
793 | 794 | | |
794 | | - | |
795 | 795 | | |
796 | 796 | | |
797 | 797 | | |
| |||
866 | 866 | | |
867 | 867 | | |
868 | 868 | | |
869 | | - | |
870 | | - | |
871 | | - | |
872 | | - | |
873 | | - | |
| 869 | + | |
| 870 | + | |
| 871 | + | |
| 872 | + | |
| 873 | + | |
874 | 874 | | |
875 | 875 | | |
| 876 | + | |
876 | 877 | | |
877 | 878 | | |
878 | 879 | | |
879 | 880 | | |
880 | | - | |
881 | 881 | | |
882 | 882 | | |
883 | 883 | | |
| |||
1063 | 1063 | | |
1064 | 1064 | | |
1065 | 1065 | | |
| 1066 | + | |
1066 | 1067 | | |
1067 | 1068 | | |
1068 | 1069 | | |
1069 | | - | |
1070 | 1070 | | |
1071 | 1071 | | |
1072 | 1072 | | |
| |||
0 commit comments