Made collections readonly

Author: TwoTenPvP

MLAPI/Data/Cache.cs

@@ -5,8 +5,8 @@ namespace MLAPI.Data
 {
     internal static class Cache
     {
-        internal static Dictionary<string, ulong> messageAttributeHashes = new Dictionary<string, ulong>();
-        internal static Dictionary<ulong, string> messageAttributeNames = new Dictionary<ulong, string>();
+        internal static readonly Dictionary<string, ulong> messageAttributeHashes = new Dictionary<string, ulong>();
+        internal static readonly Dictionary<ulong, string> messageAttributeNames = new Dictionary<ulong, string>();
 
         internal static ulong GetMessageAttributeHash(string name, AttributeMessageMode mode)
         {

MLAPI/MonoBehaviours/Core/NetworkingManager.cs

@@ -65,7 +65,7 @@ public uint MyClientId
             }
         }
         internal uint myClientId;
-        internal Dictionary<uint, NetworkedClient> connectedClients;
+        internal readonly Dictionary<uint, NetworkedClient> connectedClients = new Dictionary<uint, NetworkedClient>();
         /// <summary>
         /// Gets a dictionary of connected clients
         /// </summary>
@@ -76,7 +76,7 @@ public Dictionary<uint, NetworkedClient> ConnectedClients
                 return connectedClients;
             }
         }
-        internal HashSet<uint> pendingClients;
+        internal readonly HashSet<uint> pendingClients = new HashSet<uint>();
         internal bool _isServer;
         internal bool _isClient;
         /// <summary>
@@ -146,7 +146,7 @@ public bool IsClientConnected
         public NetworkConfig NetworkConfig;
 
         internal EllipticDiffieHellman clientDiffieHellman;
-        internal Dictionary<uint, byte[]> diffieHellmanPublicKeys;
+        internal readonly Dictionary<uint, byte[]> diffieHellmanPublicKeys = new Dictionary<uint, byte[]>();
         internal byte[] clientAesKey;
 
         /// <summary>
@@ -220,26 +220,26 @@ private object Init(bool server)
             lastEventTickTime = 0f;
             lastReceiveTickTime = 0f;
             eventOvershootCounter = 0f;
-            pendingClients = new HashSet<uint>();
-            connectedClients = new Dictionary<uint, NetworkedClient>();
+            pendingClients.Clear();
+            connectedClients.Clear();
             messageBuffer = new byte[NetworkConfig.MessageBufferSize];
-            diffieHellmanPublicKeys = new Dictionary<uint, byte[]>();
-            Data.Cache.messageAttributeHashes = new Dictionary<string, ulong>();
-            Data.Cache.messageAttributeNames = new Dictionary<ulong, string>();
-            MessageManager.channels = new Dictionary<string, int>();
-            MessageManager.messageTypes = new Dictionary<string, ushort>();
-            MessageManager.messageCallbacks = new Dictionary<ushort, Dictionary<int, Action<uint, BitReader>>>();
-            MessageManager.messageHandlerCounter = new Dictionary<ushort, int>();
-            MessageManager.releasedMessageHandlerCounters = new Dictionary<ushort, Stack<int>>();
-            MessageManager.reverseChannels = new Dictionary<int, string>();
-            MessageManager.reverseMessageTypes = new Dictionary<ushort, string>();
-            SpawnManager.spawnedObjects = new Dictionary<uint, NetworkedObject>();
-            SpawnManager.releasedNetworkObjectIds = new Stack<uint>();
-            NetworkPoolManager.Pools = new Dictionary<ushort, NetworkPool>();
-            NetworkPoolManager.PoolNamesToIndexes = new Dictionary<string, ushort>();
-            NetworkSceneManager.registeredSceneNames = new HashSet<string>();
-            NetworkSceneManager.sceneIndexToString = new Dictionary<uint, string>();
-            NetworkSceneManager.sceneNameToIndex = new Dictionary<string, uint>();
+            diffieHellmanPublicKeys.Clear();
+            Data.Cache.messageAttributeHashes.Clear();
+            Data.Cache.messageAttributeNames.Clear();
+            MessageManager.channels.Clear();
+            MessageManager.messageTypes.Clear();
+            MessageManager.messageCallbacks.Clear();
+            MessageManager.messageHandlerCounter.Clear();
+            MessageManager.releasedMessageHandlerCounters.Clear();
+            MessageManager.reverseChannels.Clear();
+            MessageManager.reverseMessageTypes.Clear();
+            SpawnManager.spawnedObjects.Clear();
+            SpawnManager.releasedNetworkObjectIds.Clear();
+            NetworkPoolManager.Pools.Clear();
+            NetworkPoolManager.PoolNamesToIndexes.Clear();
+            NetworkSceneManager.registeredSceneNames.Clear();
+            NetworkSceneManager.sceneIndexToString.Clear();
+            NetworkSceneManager.sceneNameToIndex.Clear();
             InternalMessageHandler.FinalMessageBuffer = new byte[NetworkConfig.MessageBufferSize];
 
             if (NetworkConfig.Transport == DefaultTransport.UNET)

MLAPI/NetworkingManagerComponents/Core/MessageManager.cs

@@ -7,14 +7,14 @@ namespace MLAPI.NetworkingManagerComponents.Core
 {
     internal static class MessageManager
     {
-        internal static Dictionary<string, int> channels;
-        internal static Dictionary<int, string> reverseChannels;
-        internal static Dictionary<string, ushort> messageTypes;
-        internal static Dictionary<ushort, string> reverseMessageTypes;
-        
-        internal static Dictionary<ushort, Dictionary<int, Action<uint, BitReader>>> messageCallbacks;
-        internal static Dictionary<ushort, int> messageHandlerCounter;
-        internal static Dictionary<ushort, Stack<int>> releasedMessageHandlerCounters;
+        internal static readonly Dictionary<string, int> channels = new Dictionary<string, int>();
+        internal static readonly Dictionary<int, string> reverseChannels = new Dictionary<int, string>();
+        internal static readonly Dictionary<string, ushort> messageTypes = new Dictionary<string, ushort>();
+        internal static readonly Dictionary<ushort, string> reverseMessageTypes = new Dictionary<ushort, string>();
+
+        internal static readonly Dictionary<ushort, Dictionary<int, Action<uint, BitReader>>> messageCallbacks = new Dictionary<ushort, Dictionary<int, Action<uint, BitReader>>>();
+        internal static readonly Dictionary<ushort, int> messageHandlerCounter = new Dictionary<ushort, int>();
+        internal static readonly Dictionary<ushort, Stack<int>> releasedMessageHandlerCounters = new Dictionary<ushort, Stack<int>>();
 
         private static NetworkingManager netManager
         {

MLAPI/NetworkingManagerComponents/Core/NetworkPoolManager.cs

@@ -11,9 +11,9 @@ namespace MLAPI.NetworkingManagerComponents.Core
     /// </summary>
     public static class NetworkPoolManager
     {
-        internal static Dictionary<ushort, NetworkPool> Pools;
+        internal static readonly Dictionary<ushort, NetworkPool> Pools = new Dictionary<ushort, NetworkPool>();
         private static ushort PoolIndex = 0;
-        internal static Dictionary<string, ushort> PoolNamesToIndexes;
+        internal static readonly Dictionary<string, ushort> PoolNamesToIndexes = new Dictionary<string, ushort>();
 
         /// <summary>
         /// Creates a networked object pool. Can only be called from the server

MLAPI/NetworkingManagerComponents/Core/NetworkSceneManager.cs

@@ -12,9 +12,9 @@ namespace MLAPI.NetworkingManagerComponents.Core
     /// </summary>
     public static class NetworkSceneManager
     {
-        internal static HashSet<string> registeredSceneNames;
-        internal static Dictionary<string, uint> sceneNameToIndex;
-        internal static Dictionary<uint, string> sceneIndexToString;
+        internal static readonly HashSet<string> registeredSceneNames = new HashSet<string>();
+        internal static readonly Dictionary<string, uint> sceneNameToIndex = new Dictionary<string, uint>();
+        internal static readonly Dictionary<uint, string> sceneIndexToString = new Dictionary<uint, string>();
         private static Scene lastScene;
         private static Scene nextScene;
         private static bool isSwitching = false;

MLAPI/NetworkingManagerComponents/Core/SpawnManager.cs

@@ -8,8 +8,8 @@ namespace MLAPI.NetworkingManagerComponents.Core
 {
     internal static class SpawnManager
     {
-        internal static Dictionary<uint, NetworkedObject> spawnedObjects;
-        internal static Stack<uint> releasedNetworkObjectIds;
+        internal static readonly Dictionary<uint, NetworkedObject> spawnedObjects = new Dictionary<uint, NetworkedObject>();
+        internal static readonly Stack<uint> releasedNetworkObjectIds = new Stack<uint>();
         private static uint networkObjectIdCounter;
         internal static uint GetNetworkObjectId()
         {